Details

Reviewers

movrcx
schancel

Group Reviewers

Restricted Project
Restricted Owners Package	(Owns No Changed Paths)

Maniphest Tasks

T307: Adds OP_CAT functionality into interpreter.cpp
T308: Adds OP_SPLIT functionality into interpreter.cpp

Summary

Add handling for CAT and SPLIT opcodes when the monolith script flag is enabled.

Co-authored-by: Joshua Yabut <yabut.joshua@gmail.com>
Co-authored-by: Marcos Mayorga <mm@mm-studios.com>

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

arcpatch-D1097

Lint

Lint Skipped

Unit

No Test Coverage

Build Status

Buildable 2191
Build 2526: Bitcoin ABC Buildbot (legacy)
Build 2525: arc lint + arc unit

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Harbormaster completed remote builds in B1849: Diff 2872.Feb 15 2018, 01:03

movrcx added parent revisions: D1090: Adds Bitwise functionality into interpreter.cpp, D1096: unit test for OP_MOD, D1095: Adds OP_MOD functionality into interpreter.cpp, D1094: unit test for OP_DIV, D1093: Adds OP_DIV functionality into interpreter.cpp, D1092: unit test for bitwise operations (AND, OR, XOR), D1091: unit test removal OP_LEFT/RIGHT/SUBSTR.Feb 15 2018, 01:04

movrcx added a child revision: D1098: unit test for OP_CAT.

Fixing auto-linting

Harbormaster completed remote builds in B1852: Diff 2875.Feb 15 2018, 01:10

movrcx added a child revision: D1099: Adds OP_SPLIT functionality into interpreter.cpp.Feb 15 2018, 01:15

movrcx added a child revision: D1101: Adds OP_BIN2NUM functionality into interpreter.cpp.Feb 15 2018, 01:21

movrcx added a child revision: D1103: Add support for NUM2BIN, and BIN2NUM opcodes.Feb 15 2018, 01:26

movrcx edited the summary of this revision. (Show Details)Feb 15 2018, 01:57

movrcx edited the summary of this revision. (Show Details)

shadders added a subscriber: shadders.Feb 15 2018, 03:23

Adds unit tests

Harbormaster completed remote builds in B1875: Diff 2899.Feb 16 2018, 08:17

danconnolly added a subscriber: danconnolly.Feb 21 2018, 08:51

movrcx added a child revision: D1142: Added tests for disabled opcodes before/after the fork..Feb 28 2018, 01:57

schancel removed parent revisions: D1091: unit test removal OP_LEFT/RIGHT/SUBSTR, D1092: unit test for bitwise operations (AND, OR, XOR), D1094: unit test for OP_DIV, D1096: unit test for OP_MOD.Mar 9 2018, 10:48

schancel removed a child revision: D1142: Added tests for disabled opcodes before/after the fork..

schancel removed a child revision: D1098: unit test for OP_CAT.Mar 9 2018, 10:58

schancel removed parent revisions: D1093: Adds OP_DIV functionality into interpreter.cpp, D1090: Adds Bitwise functionality into interpreter.cpp.Mar 9 2018, 11:02

schancel removed a child revision: D1103: Add support for NUM2BIN, and BIN2NUM opcodes.

schancel removed a child revision: D1101: Adds OP_BIN2NUM functionality into interpreter.cpp.

resubmit D1097, corrected for changes in other diffs further down the stack

Owners added a reviewer: Restricted Owners Package.Mar 12 2018, 19:30

Herald added 1 blocking reviewer(s): Restricted Project. · View Herald TranscriptMar 12 2018, 19:30

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2053: Diff 3157.Mar 12 2018, 19:53

Cleaning up due to D1202

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging failed.

Harbormaster failed remote builds in B2107: Diff 3225!Mar 16 2018, 03:01

Rebase off of master

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging failed.

Harbormaster failed remote builds in B2134: Diff 3255!Mar 17 2018, 02:57

schancel commandeered this revision.Mar 18 2018, 02:04

schancel added a reviewer: movrcx.

Rebase and cleanup, no tests yet

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2145: Diff 3269.Mar 18 2018, 02:39

Wut

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

fuuu arc

schancel retitled this revision from Adds OP_CAT functionality into interpreter.cpp to Add support for CAT, and SPLIT opcodes.Mar 18 2018, 02:45

schancel edited the summary of this revision. (Show Details)

schancel edited the test plan for this revision. (Show Details)

Harbormaster failed remote builds in B2146: Diff 3270!Mar 18 2018, 02:55

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging failed.

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging failed.

Harbormaster failed remote builds in B2148: Diff 3272!Mar 18 2018, 03:12

schancel removed a child revision: D1099: Adds OP_SPLIT functionality into interpreter.cpp.Mar 18 2018, 03:14

schancel removed a parent revision: D1095: Adds OP_MOD functionality into interpreter.cpp.

schancel added a child revision: D1194: Set Monolith opcode enable script flag if monolith enabled.

schancel added a task: T308: Adds OP_SPLIT functionality into interpreter.cpp.Mar 18 2018, 03:44

schancel added a task: T307: Adds OP_CAT functionality into interpreter.cpp.

Add in a few tests. Still more required.

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2153: Diff 3277.Mar 18 2018, 06:51

More test cases

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

schancel edited the summary of this revision. (Show Details)Mar 18 2018, 07:02

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2154: Diff 3278.Mar 18 2018, 07:19

Use popstack instead of pop_back()

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Harbormaster completed remote builds in B2157: Diff 3281.Mar 18 2018, 07:55

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Add more tests

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Harbormaster completed remote builds in B2177: Diff 3303.Mar 19 2018, 10:38

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Refactored old tests

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Harbormaster completed remote builds in B2191: Diff 3323.Mar 21 2018, 16:42

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

jasonbcox mentioned this in D1223: Refactored existing monolith_opcodes tests.Mar 29 2018, 03:41

jasonbcox mentioned this in rABC5857e829f528: Refactored existing monolith_opcodes tests.Mar 29 2018, 19:44

deadalnix commandeered this revision.Mar 31 2018, 08:34

deadalnix abandoned this revision.

deadalnix added a reviewer: schancel.

jasonbcox mentioned this in rSTAGING5857e829f528: Refactored existing monolith_opcodes tests.Sep 27 2018, 18:40

Add support for CAT, and SPLIT opcodes
AbandonedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 3323

src/Makefile.test.include

src/script/interpreter.cpp

src/script/script_error.h

src/script/script_error.cpp

src/test/CMakeLists.txt

src/test/data/script_tests.json

src/test/monolith_opcodes_string.cpp

src/test/script_tests.cpp

Add support for CAT, and SPLIT opcodesAbandonedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 3323

src/Makefile.test.include

src/script/interpreter.cpp

src/script/script_error.h

src/script/script_error.cpp

src/test/CMakeLists.txt

src/test/data/script_tests.json

src/test/monolith_opcodes_string.cpp

src/test/script_tests.cpp

Add support for CAT, and SPLIT opcodes
AbandonedPublic
Actions

Revision Contents
Changeset List