Page MenuHomePhabricator

Adds OP_BIN2NUM functionality into interpreter.cpp
AbandonedPublic

Authored by schancel on Feb 15 2018, 01:18.

Details

Reviewers
movrcx
Group Reviewers
Restricted Project
Restricted Owners Package(Owns No Changed Paths)
Summary

Takes a byte string in sign magnitude little endian format and outputs a minimally-encoded number.

Co-authored-by: Marcos Mayorga <mm@mm-studios.com>
Co-authored-by: Joshua Yabut <yabut.joshua@gmail.com>

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint SkippedExcuse: Unnecessary changes to previous code.
Unit
No Unit Test Coverage
Build Status
Buildable 2136
Build 2416: Bitcoin ABC Teamcity Staging
Build 2415: arc lint + arc unit

Event Timeline

movrcx created this revision.Feb 15 2018, 01:18
movrcx edited the summary of this revision. (Show Details)Feb 15 2018, 01:57
movrcx updated this revision to Diff 2901.Feb 16 2018, 08:22

Unit tests are attached and may be executed with ./test-bitcoin --run_test=op_code

jasonbcox added inline comments.
src/script/interpreter.cpp
1300 ↗(On Diff #2901)

More descriptive comment. Something like: // big Endian to little Endian

movrcx marked an inline comment as done.Feb 28 2018, 00:25
movrcx updated this revision to Diff 3002.Feb 28 2018, 00:25

Update comments and add OP_BIN2NUM definition in script.cpp

danconnolly updated this revision to Diff 3163.Mar 12 2018, 21:23

resubmit D1101, updated for underlying changes

Owners added a reviewer: Restricted Owners Package.Mar 12 2018, 21:23
Herald added 1 blocking reviewer(s): Restricted Project. · View Herald TranscriptMar 12 2018, 21:23
danconnolly edited the test plan for this revision. (Show Details)Mar 12 2018, 21:23
movrcx updated this revision to Diff 3227.Mar 16 2018, 02:57

Cleaning up due to D1202

movrcx updated this revision to Diff 3257.Mar 17 2018, 02:20

Rebase off of master

schancel commandeered this revision.Mar 18 2018, 02:59
schancel abandoned this revision.
schancel added a reviewer: movrcx.