Page MenuHomePhabricator

Adds OP_BIN2NUM functionality into interpreter.cpp

Authored by schancel on Feb 15 2018, 01:18.


Group Reviewers
Restricted Project
Restricted Owners Package(Owns No Changed Paths)

Takes a byte string in sign magnitude little endian format and outputs a minimally-encoded number.

Co-authored-by: Marcos Mayorga <>
Co-authored-by: Joshua Yabut <>

Test Plan

make check

Diff Detail

Event Timeline

Unit tests are attached and may be executed with ./test-bitcoin --run_test=op_code

jasonbcox added inline comments.
1300 ↗(On Diff #2901)

More descriptive comment. Something like: // big Endian to little Endian

movrcx marked an inline comment as done.Feb 28 2018, 00:25

Update comments and add OP_BIN2NUM definition in script.cpp

resubmit D1101, updated for underlying changes

Owners added a reviewer: Restricted Owners Package.Mar 12 2018, 21:23
Herald added 1 blocking reviewer(s): Restricted Project. · View Herald TranscriptMar 12 2018, 21:23
schancel abandoned this revision.
schancel added a reviewer: movrcx.