Adds scaffolding for opcode deployment
Details
Diff Detail
- Repository
- rABC Bitcoin ABC
- Lint
Lint Skipped - Unit
No Test Coverage - Build Status
Buildable 2130 Build 2404: Bitcoin ABC Buildbot (legacy) Build 2403: arc lint + arc unit
Event Timeline
script_test.cpp doesn't have the new error codes added in it.
This list also needs to be updated:
https://reviews.bitcoinabc.org/source/bitcoin-abc/browse/master/src/test/script_tests.cpp;0d1b49c9f37f8549540521e6e02a27c261c6da5a$54
Rename this for clarity (in scripts_test.cpp)
static const unsigned int flags = SCRIPT_VERIFY_P2SH | SCRIPT_VERIFY_STRICTENC;
static const unsigned int defaultTestFlags = SCRIPT_VERIFY_P2SH | SCRIPT_VERIFY_STRICTENC;
src/test/monolith_opcodes.cpp | ||
---|---|---|
119โ135 โ | (On Diff #3239) | Not blocking for the release, but this can be rewritten to loop through these values rather than copy-pasting the test. |
src/test/data/script_tests.json | ||
---|---|---|
846 | Adding some tests as commented in the slack channel for posterity: | |
850 | Adding some tests as commented in the slack channel for posterity: | |
853โ854 | OP_SPLIT needs tests for SCRIPT_ERR_INVALID_STACK_OPERATION and SCRIPT_ERR_INVALID_SPLIT_RANGE | |
855โ856 | BIN2NUM and NUM2BIN need tests for SCRIPT_ERR_INVALID_STACK_OPERATION |