Paths

Table of Contentst

Differential D10097

wallet: IsChange requires cs_wallet lock
ClosedPublic
Actions

Authored by PiRK on Sep 13 2021, 14:37.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCc0a3007e5e02: wallet: IsChange requires cs_wallet lock

Summary

This is a backport of core#19289 [3/3]
https://github.com/bitcoin/bitcoin/pull/19289/commits/b8405b833ad28351c80fb10f6f896f974013fd9e

Depends on D10096

Test Plan

With Clang and Debug:
ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Sep 13 2021, 14:37

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 13 2021, 14:37

PiRK requested review of this revision.Sep 13 2021, 14:37

teamcity edited the summary of this revision. (Show Details)Sep 13 2021, 14:38

PiRK edited the summary of this revision. (Show Details)Sep 13 2021, 14:38

PiRK added a parent revision: D10096: wallet: IsMine overloads require cs_wallet lock.

Harbormaster completed remote builds in B16620: Diff 29907.Sep 13 2021, 15:00

PiRK added a child revision: D10099: wallet, refactor: Immutable CWalletTx::pwallet.Sep 13 2021, 15:09

Please take care to use the appropriate test plan. This one was not good (I edited), but luckily the CI did the job.

This revision is now accepted and ready to land.Sep 13 2021, 18:49

Closed by commit rABCc0a3007e5e02: wallet: IsChange requires cs_wallet lock (authored by João Barbosa <joao.paulo.barbosa@gmail.com>, committed by PiRK). · Explain WhySep 14 2021, 06:26

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCc0a3007e5e02: wallet: IsChange requires cs_wallet lock.

Revision Contents
Changeset List

Path

Size

src/

wallet/

wallet.h

9 lines

wallet.cpp

4 lines

Diff 29930

View Options

src/wallet/wallet.h