Page MenuHomePhabricator

wallet, refactor: Immutable CWalletTx::pwallet
ClosedPublic

Authored by PiRK on Mon, Sep 13, 15:09.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC819580a50c41: wallet, refactor: Immutable CWalletTx::pwallet
Summary

PR description:

This change moves CWalletTx::IsTrusted to CWallet in order to have TSAN. So now CWallet::IsTrusted requires cs_wallet and the recursive lock no longer happens.

This is a backport of core#19773 [1/2]
https://github.com/bitcoin/bitcoin/pull/19773/commits/819f10f6718659eeeec13af2ce831df3a0984090

Depends on D10097

Test Plan

With TSAN:
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable