Page MenuHomePhabricator

Adds OP_SPLIT functionality into interpreter.cpp
AbandonedPublic

Authored by schancel on Feb 15 2018, 01:13.

Details

Reviewers
movrcx
Group Reviewers
Restricted Project
Restricted Owners Package(Owns No Changed Paths)
Summary

Creates a new opcode OP_SPLIT that is used to bisect a bytestring.

Co-authored-by: Joshua Yabut <yabut.joshua@gmail.com>
Co-authored-by: Marcos Mayorga <mm@mm-studios.com>

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint SkippedExcuse: Unnecessary changes to previous code.
Unit
No Unit Test Coverage
Build Status
Buildable 2135
Build 2414: Bitcoin ABC Teamcity Staging
Build 2413: arc lint + arc unit

Event Timeline

movrcx created this revision.Feb 15 2018, 01:13
movrcx edited the summary of this revision. (Show Details)Feb 15 2018, 01:57
movrcx edited the summary of this revision. (Show Details)
movrcx updated this revision to Diff 2900.Feb 16 2018, 08:20

Unit tests are attached and may be executed with ./test-bitcoin --run_test=op_code

danconnolly edited the test plan for this revision. (Show Details)Mar 12 2018, 20:13
danconnolly updated this revision to Diff 3162.Mar 12 2018, 20:52

resubmit D1099 - OP_SPLIT

Owners added a reviewer: Restricted Owners Package.Mar 12 2018, 20:52
Herald added 1 blocking reviewer(s): Restricted Project. · View Herald TranscriptMar 12 2018, 20:52
movrcx updated this revision to Diff 3226.Mar 16 2018, 02:49

Cleaning up due to D1202

movrcx updated this revision to Diff 3256.Mar 17 2018, 02:19

Rebase off of master

schancel commandeered this revision.Mar 18 2018, 02:16
schancel added a reviewer: movrcx.
schancel abandoned this revision.Mar 18 2018, 02:25