Page MenuHomePhabricator

Add support for CAT, and SPLIT opcodes
AbandonedPublic

Authored by deadalnix on Feb 15 2018, 01:02.

Details

Reviewers
movrcx
schancel
Group Reviewers
Restricted Project
Restricted Owners Package(Owns No Changed Paths)
Maniphest Tasks
T307: Adds OP_CAT functionality into interpreter.cpp
T308: Adds OP_SPLIT functionality into interpreter.cpp
Summary

Add handling for CAT and SPLIT opcodes when the monolith script flag is enabled.

Co-authored-by: Joshua Yabut <yabut.joshua@gmail.com>
Co-authored-by: Marcos Mayorga <mm@mm-studios.com>

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
arcpatch-D1097
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2148
Build 2440: Bitcoin ABC Buildbot (legacy)
Build 2439: arc lint + arc unit

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
movrcx edited the summary of this revision. (Show Details)

resubmit D1097, corrected for changes in other diffs further down the stack

Owners added a reviewer: Restricted Owners Package.Mar 12 2018, 19:30
Herald added 1 blocking reviewer(s): Restricted Project. · View Herald TranscriptMar 12 2018, 19:30
schancel added a reviewer: movrcx.

Rebase and cleanup, no tests yet

schancel retitled this revision from Adds OP_CAT functionality into interpreter.cpp to Add support for CAT, and SPLIT opcodes.Mar 18 2018, 02:45
schancel edited the summary of this revision. (Show Details)
schancel edited the test plan for this revision. (Show Details)

Add in a few tests. Still more required.

Use popstack instead of pop_back()

macros added a subscriber: macros.

Refactored old tests

deadalnix abandoned this revision.
deadalnix added a reviewer: schancel.