Page MenuHomePhabricator
Differential D13734

[alias spec] Remove comment about refunds
ClosedPublic
Actions

Authored by Mengerian on Apr 17 2023, 20:58.

Details

Reviewers
emack
bytesofman
Group Reviewers
Restricted Project
Commits
rABC0779ad83448f: [alias spec] Remove comment about refunds
Summary

This doesn't belong in the technical spec, even if there is an effort made to refund mistakes or duplicates, and can't be guaranteed.

Test Plan

Read it to make sure the info is correct

Diff Detail

Repository
rABC Bitcoin ABC
Branch
alias-spec-refunds
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 23351
Build 46321: Build Diff
Build 46320: arc lint + arc unit

Event Timeline

Mengerian created this revision.Apr 17 2023, 20:58
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 17 2023, 20:58
Mengerian requested review of this revision.Apr 17 2023, 20:58
Harbormaster completed remote builds in B23351: Diff 39789.Apr 17 2023, 20:59
emack requested changes to this revision.Apr 18 2023, 04:34
emack added inline comments.
doc/standards/xec-alias.md
59

Agree with removing the refunding statement however we should still mention how invalid transactions are handled given the flow of this section.
i.e.:
Invalid transactions that do not match the criteria above should be ignored by the app parsing the payment address history.

This revision now requires changes to proceed.Apr 18 2023, 04:34
Mengerian updated this revision to Diff 39795.Apr 18 2023, 14:24

Add statment saying invalid registration transaction should be ignored

Harbormaster completed remote builds in B23356: Diff 39795.Apr 18 2023, 14:24
emack accepted this revision.Apr 18 2023, 14:29
This revision is now accepted and ready to land.Apr 18 2023, 14:29
Closed by commit rABC0779ad83448f: [alias spec] Remove comment about refunds (authored by Mengerian). · Explain WhyApr 18 2023, 15:11
This revision was automatically updated to reflect the committed changes.
Mengerian added a commit: rABC0779ad83448f: [alias spec] Remove comment about refunds.

Revision Contents
Changeset List

PathSize
doc/
standards/
2 lines

Diff 39789

View Options

doc/standards/xec-alias.md

Loading...