Page MenuHomePhabricator
Differential D13736

[alias spec] Remove info about non-alphanumeric aliases
ClosedPublic
Actions

Authored by Mengerian on Apr 18 2023, 15:55.

Details

Reviewers
bytesofman
emack
Group Reviewers
Restricted Project
Commits
rABC56affaf6f32c: [alias spec] Remove info about non-alphanumeric aliases
Summary

Also specify that they're utf-8 encoded.
In effect this makes the characters all 1 byte ASCII equivalent, due to the aplphanumeric restriction.

Test Plan

Read to see that it makes sense

Diff Detail

Repository
rABC Bitcoin ABC
Branch
alias-spec-lowercase
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 23366
Build 46351: Build Diff
Build 46350: arc lint + arc unit

Event Timeline

Mengerian created this revision.Apr 18 2023, 15:55
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 18 2023, 15:55
Mengerian requested review of this revision.Apr 18 2023, 15:55
Harbormaster completed remote builds in B23357: Diff 39797.Apr 18 2023, 15:55
Mengerian added a child revision: D13737: [alias spec] Reword specification to make it more descriptive.Apr 18 2023, 19:50
emack requested changes to this revision.Apr 19 2023, 08:09
emack added inline comments.
doc/standards/xec-alias.md
52 ↗(On Diff #39797)

the alphanumeric input is now limited to 1 and 21 **bytes** in length

This revision now requires changes to proceed.Apr 19 2023, 08:09
Mengerian updated this revision to Diff 39807.Apr 19 2023, 15:49

characters -> bytes

Harbormaster completed remote builds in B23366: Diff 39807.Apr 19 2023, 15:49
emack accepted this revision.Apr 20 2023, 01:23
This revision is now accepted and ready to land.Apr 20 2023, 01:23
Closed by commit rABC56affaf6f32c: [alias spec] Remove info about non-alphanumeric aliases (authored by Mengerian). · Explain WhyApr 20 2023, 02:25
This revision was automatically updated to reflect the committed changes.
Mengerian added a commit: rABC56affaf6f32c: [alias spec] Remove info about non-alphanumeric aliases.

Revision Contents
Changeset List

PathSize
doc/
standards/
4 lines

Diff 39807

View Options

doc/standards/xec-alias.md

Loading...