Page MenuHomePhabricator
Differential D13737

[alias spec] Reword specification to make it more descriptive
ClosedPublic
Actions

Authored by Mengerian on Apr 18 2023, 19:50.

Details

Reviewers
bytesofman
emack
Group Reviewers
Restricted Project
Commits
rABC1b75fee488eb: [alias spec] Reword specification to make it more descriptive
Summary

Mostly just more detailed descriptions of the various pieces.
Still needs more work, but this is a step towards making it more complete.

Also changes the spec to having the Alias Address defined in an op-return push rather than the sending "from" address.

Depends on D13736

Test Plan

Read it to see that it all makes sense

Diff Detail

Repository
rABC Bitcoin ABC
Branch
alias-spec-reword
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 23359
Build 46337: Build Diff
Build 46336: arc lint + arc unit

Event Timeline

Mengerian created this revision.Apr 18 2023, 19:50
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 18 2023, 19:50
Mengerian requested review of this revision.Apr 18 2023, 19:50
Harbormaster completed remote builds in B23358: Diff 39799.Apr 18 2023, 19:50
Mengerian updated this revision to Diff 39800.Apr 18 2023, 19:52
Mengerian retitled this revision from [alias spec] Reword specification to make it more descriptive Mostly just more detailed descriptions of the various pieces. Still needs more work, but this is a step towards making it more complete. to [alias spec] Reword specification to make it more descriptive.
Mengerian edited the summary of this revision. (Show Details)

Fix Diff title

Harbormaster completed remote builds in B23359: Diff 39800.Apr 18 2023, 19:52
Mengerian updated this revision to Diff 39801.Apr 18 2023, 19:54
Mengerian edited the summary of this revision. (Show Details)

Edit Diff description to mention spec change of how the Alias Address is defined

Harbormaster completed remote builds in B23360: Diff 39801.Apr 18 2023, 19:54
emack added a comment.Apr 19 2023, 08:21

minor nits below. Will defer to joey for further input as this is a bit of a rework in both cashtab and alias server.

doc/standards/xec-alias.md
56 ↗(On Diff #39801)

by the number of **bytes** in the alias...

62 ↗(On Diff #39801)

lowercase e, i.e. 2e786563

Mengerian updated this revision to Diff 39808.Apr 19 2023, 16:04

Rebase

Harbormaster completed remote builds in B23367: Diff 39808.Apr 19 2023, 16:04
Mengerian updated this revision to Diff 39809.Apr 19 2023, 16:06

characters -> bytes

Harbormaster completed remote builds in B23368: Diff 39809.Apr 19 2023, 16:06
Mengerian added a comment.Apr 19 2023, 16:07

Changes "characters" to "bytes", though with the alphanumeric restriction these should be equivalent

emack accepted this revision.Apr 20 2023, 01:17
This revision is now accepted and ready to land.Apr 20 2023, 01:17
Closed by commit rABC1b75fee488eb: [alias spec] Reword specification to make it more descriptive (authored by Mengerian). · Explain WhyApr 20 2023, 02:42
This revision was automatically updated to reflect the committed changes.
Mengerian added a commit: rABC1b75fee488eb: [alias spec] Reword specification to make it more descriptive.

Revision Contents
Changeset List

PathSize
doc/
standards/
52 lines

Diff 39800

View Options

doc/standards/xec-alias.md

Loading...