[Chronik] Use `is_final_height` in `make_tx_proto`
ClosedPublic
Actions

Authored by tobias_ruck on Apr 24 2023, 20:01.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC288f233088a1: [Chronik] Use `is_final_height` in `make_tx_proto`

Summary

This has been overlooked before.

Test Plan

ninja check-crates && ninja check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Branch

chronik-use-is_final_height

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 23430
Build 46479: Build Diff	build-chronik
Build 46478: arc lint + arc unit

Event Timeline

tobias_ruck created this revision.Apr 24 2023, 20:01

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 24 2023, 20:01

tobias_ruck requested review of this revision.Apr 24 2023, 20:01

Fabien accepted this revision.Apr 24 2023, 20:04

This revision is now accepted and ready to land.Apr 24 2023, 20:04

tobias_ruck mentioned this in D13763: [Chronik] Add `/script/:type/:payload/utxos` HTTP endpoint.Apr 24 2023, 20:15

Harbormaster completed remote builds in B23430: Diff 39906.Apr 24 2023, 20:49

Closed by commit rABC288f233088a1: [Chronik] Use `is_final_height` in `make_tx_proto` (authored by tobias_ruck). · Explain WhyApr 25 2023, 10:30

This revision was automatically updated to reflect the committed changes.

tobias_ruck added a commit: rABC288f233088a1: [Chronik] Use `is_final_height` in `make_tx_proto`.

Revision Contents
Changeset List

Path

Size

chronik/

chronik-indexer/

src/

query/

util.rs

2 lines

Diff 39906

View Options

chronik/chronik-indexer/src/query/util.rs

[Chronik] Use `is_final_height` in `make_tx_proto`ClosedPublicActions