Page MenuHomePhabricator
Differential D13787

[Chronik] Require subscribing to WebSocket block updates
ClosedPublic
Actions

Authored by tobias_ruck on Apr 26 2023, 11:19.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC0908f22bd441: [Chronik] Require subscribing to WebSocket block updates
Summary

Require sending WsSub protobuf message to the server to subscribe to blocks, before sending out block updates.

NNG Chronik sent these unconditionally, but since we now have a more flexible subscription API, we can give users different subscription options.

Test Plan

ninja && ./test/functional/test_runner.py chronik_ws

Diff Detail

Repository
rABC Bitcoin ABC
Branch
chronik-ws-require-sub
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 23471
Build 46561: Build Diffbuild-chronik · build-without-wallet · build-debug · build-diff · build-clang · build-clang-tidy
Build 46560: arc lint + arc unit

Event Timeline

tobias_ruck requested review of this revision.Apr 26 2023, 11:19
tobias_ruck created this revision.
Harbormaster completed remote builds in B23470: Diff 39957.Apr 26 2023, 11:33
teamcity added a comment.Apr 26 2023, 11:33
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
tobias_ruck updated this revision to Diff 39958.Apr 26 2023, 11:55

Fix pending

tobias_ruck mentioned this in D13781: [Chronik] Allow subscribing to WebSocket script updates.Apr 26 2023, 12:00
Harbormaster completed remote builds in B23471: Diff 39958.Apr 26 2023, 12:12
Fabien accepted this revision.Apr 26 2023, 13:32
This revision is now accepted and ready to land.Apr 26 2023, 13:32
Closed by commit rABC0908f22bd441: [Chronik] Require subscribing to WebSocket block updates (authored by tobias_ruck). · Explain WhyApr 26 2023, 13:47
This revision was automatically updated to reflect the committed changes.
tobias_ruck added a commit: rABC0908f22bd441: [Chronik] Require subscribing to WebSocket block updates.

Revision Contents
Changeset List

PathSize
chronik/
chronik-http/
src/
75 lines
chronik-indexer/
src/
4 lines
chronik-proto/
proto/
15 lines
test/
functional/
7 lines
test_framework/
chronik/
7 lines

Diff 39958

View Options

chronik/chronik-http/src/ws.rs

Loading...
View Options

chronik/chronik-indexer/src/indexer.rs

Loading...
View Options

chronik/chronik-proto/proto/chronik.proto

Loading...
View Options

test/functional/chronik_ws.py

Loading...
View Options

test/functional/test_framework/chronik/client.py

Loading...