Use TxId in miner_tests.cpp
ClosedPublic
Actions

Authored by deadalnix on May 7 2018, 20:26.

Details

Reviewers

schancel
matiu

Group Reviewers

Restricted Project

Commits

rSTAGING5df0bfeb72c3: Use TxId in miner_tests.cpp
rABC5df0bfeb72c3: Use TxId in miner_tests.cpp

Summary

Also Use C++11 style loops in there.

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

minertestrefac

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 2536
Build 3191: Bitcoin ABC Buildbot (legacy)
Build 3190: arc lint + arc unit

Event Timeline

deadalnix created this revision.May 7 2018, 20:26

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 7 2018, 20:26

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2536: Diff 3807.May 7 2018, 20:50

schancel accepted this revision.May 8 2018, 05:29

This revision is now accepted and ready to land.May 8 2018, 05:29

matiu accepted this revision.May 8 2018, 15:54

matiu added a subscriber: matiu.

matiu added inline comments.

src/test/miner_tests.cpp
153	Much nicer! 💯

Closed by commit rABC5df0bfeb72c3: Use TxId in miner_tests.cpp (authored by deadalnix). · Explain WhyMay 8 2018, 23:49

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

test/

miner_tests.cpp

66 lines

Diff 3807

View Options

Use TxId in miner_tests.cppClosedPublicActions