Page MenuHomePhabricator

[explorer] Lint the explorer
ClosedPublic

Authored by Fabien on May 1 2023, 13:21.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Commits
rABCa4d202e5af50: [explorer] Lint the explorer
Summary

This undo some of the formatting from older prettier versions.

Test Plan
arc lint -- web/explorer/explorer-server/templates/pages/*

Check your linter agrees with mine.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien requested review of this revision.May 1 2023, 13:21
arc patch 13834
arc lint

It reverts this change

Auto-Fix  (PRETTIER) Code style violation
   '~/bitcoin-abc/web/explorer/explorer-server/templates/pages/address.html'
   has code style errors.

            162 
            163             <table
            164                 id="address-txs-table"
   >>> -    165                 class="
       -    166                     block-listing__datatable
       -    167                     dataTable
       -    168                     compact
       -    169                     responsive
       -    170                     nowrap
       -    171                     no-footer
       -    172                 "
       +                        class="block-listing__datatable dataTable compact responsive nowrap no-footer"
            173                 style="width: 100%"
            174             >
            175                 <thead>
            176                     <tr>
OKAY  No lint messages.

I'm on

$ prettier -v
2.6.0
arc patch 13834
arc lint

It reverts this change

Auto-Fix  (PRETTIER) Code style violation
   '~/bitcoin-abc/web/explorer/explorer-server/templates/pages/address.html'
   has code style errors.

            162 
            163             <table
            164                 id="address-txs-table"
   >>> -    165                 class="
       -    166                     block-listing__datatable
       -    167                     dataTable
       -    168                     compact
       -    169                     responsive
       -    170                     nowrap
       -    171                     no-footer
       -    172                 "
       +                        class="block-listing__datatable dataTable compact responsive nowrap no-footer"
            173                 style="width: 100%"
            174             >
            175                 <thead>
            176                     <tr>
OKAY  No lint messages.

I'm on

$ prettier -v
2.6.0

OK I have 2.4.1, which is the minimum defined in our .arclint. I'll bump to 2.6 then

bytesofman requested changes to this revision.May 1 2023, 18:26

i think should be abandoned in light of D13837

This revision now requires changes to proceed.May 1 2023, 18:26
Fabien retitled this revision from [explorer] Lint address.html to [explorer] Lint the explorer.
Fabien edited the summary of this revision. (Show Details)
Fabien edited the test plan for this revision. (Show Details)

Lint the whole explorer with prettier 2.6.x

This revision is now accepted and ready to land.May 2 2023, 14:20
This revision was automatically updated to reflect the committed changes.