Page MenuHomePhabricator
Differential D13834

[explorer] Lint the explorer
ClosedPublic
Actions

Authored by Fabien on May 1 2023, 13:21.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Commits
rABCa4d202e5af50: [explorer] Lint the explorer
Summary

This undo some of the formatting from older prettier versions.

Test Plan
arc lint -- web/explorer/explorer-server/templates/pages/*

Check your linter agrees with mine.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
lint_html
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 23580
Build 46774: Build Diff
Build 46773: arc lint + arc unit

Event Timeline

Fabien created this revision.May 1 2023, 13:21
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 1 2023, 13:21
Fabien requested review of this revision.May 1 2023, 13:21
Harbormaster completed remote builds in B23580: Diff 40113.May 1 2023, 13:21
bytesofman added a subscriber: bytesofman.May 1 2023, 15:12
arc patch 13834
arc lint

It reverts this change

Auto-Fix  (PRETTIER) Code style violation
   '~/bitcoin-abc/web/explorer/explorer-server/templates/pages/address.html'
   has code style errors.

            162 
            163             <table
            164                 id="address-txs-table"
   >>> -    165                 class="
       -    166                     block-listing__datatable
       -    167                     dataTable
       -    168                     compact
       -    169                     responsive
       -    170                     nowrap
       -    171                     no-footer
       -    172                 "
       +                        class="block-listing__datatable dataTable compact responsive nowrap no-footer"
            173                 style="width: 100%"
            174             >
            175                 <thead>
            176                     <tr>
OKAY  No lint messages.

I'm on

$ prettier -v
2.6.0
Fabien added a comment.May 1 2023, 15:25
In D13834#308342, @bytesofman wrote:
arc patch 13834
arc lint

It reverts this change

Auto-Fix  (PRETTIER) Code style violation
   '~/bitcoin-abc/web/explorer/explorer-server/templates/pages/address.html'
   has code style errors.

            162 
            163             <table
            164                 id="address-txs-table"
   >>> -    165                 class="
       -    166                     block-listing__datatable
       -    167                     dataTable
       -    168                     compact
       -    169                     responsive
       -    170                     nowrap
       -    171                     no-footer
       -    172                 "
       +                        class="block-listing__datatable dataTable compact responsive nowrap no-footer"
            173                 style="width: 100%"
            174             >
            175                 <thead>
            176                     <tr>
OKAY  No lint messages.

I'm on

$ prettier -v
2.6.0

OK I have 2.4.1, which is the minimum defined in our .arclint. I'll bump to 2.6 then

Fabien mentioned this in D13837: [linter] Bump prettier minimum version to 2.6.0.May 1 2023, 15:36
Fabien mentioned this in rABCa29106ecd865: [linter] Bump prettier minimum version to 2.6.0.May 1 2023, 18:23
bytesofman requested changes to this revision.May 1 2023, 18:26

i think should be abandoned in light of D13837

This revision now requires changes to proceed.May 1 2023, 18:26
Fabien updated this revision to Diff 40144.May 2 2023, 14:18
Fabien retitled this revision from [explorer] Lint address.html to [explorer] Lint the explorer.
Fabien edited the summary of this revision. (Show Details)
Fabien edited the test plan for this revision. (Show Details)

Lint the whole explorer with prettier 2.6.x

Harbormaster completed remote builds in B23596: Diff 40144.May 2 2023, 14:18
bytesofman accepted this revision.May 2 2023, 14:20
This revision is now accepted and ready to land.May 2 2023, 14:20
Closed by commit rABCa4d202e5af50: [explorer] Lint the explorer (authored by Fabien). · Explain WhyMay 2 2023, 14:47
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCa4d202e5af50: [explorer] Lint the explorer.

Revision Contents
Changeset List

PathSize
web/
explorer/
explorer-server/
templates/
pages/
9 lines

Diff 40113

View Options

web/explorer/explorer-server/templates/pages/address.html

Loading...