Differential D1385

Use TxId in policyestimator_tests.cpp
ClosedPublic
Actions

Authored by deadalnix on May 8 2018, 13:32.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGb2104e609c71: Use TxId in policyestimator_tests.cpp
rABCb2104e609c71: Use TxId in policyestimator_tests.cpp

Summary

As per title, plus a few braces added for good measure.

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.May 8 2018, 13:32

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 8 2018, 13:32

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Harbormaster completed remote builds in B2542: Diff 3816.May 8 2018, 14:10

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Ping

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

deadalnix added a child revision: D1401: Update policyestimator_tests to use COutPoint's accessor..May 9 2018, 11:49

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging failed.

Harbormaster failed remote builds in B2560: Diff 3846!May 9 2018, 12:24

jasonbcox requested changes to this revision.May 9 2018, 23:30

jasonbcox added a subscriber: jasonbcox.

jasonbcox added inline comments.

src/test/policyestimator_tests.cpp
72 ↗	(On Diff #3846)	Should the 10 here be changed to txIds.size() as well? If so, the comment below this needs to be updated as N/N blocks ..., N-1/N blocks ..., etc.

This revision now requires changes to proceed.May 9 2018, 23:30

deadalnix added inline comments.May 10 2018, 00:01

src/test/policyestimator_tests.cpp
72 ↗	(On Diff #3846)	I think you are correct.

Update as per comment

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2571: Diff 3866.May 10 2018, 00:27

jasonbcox accepted this revision.May 11 2018, 22:09

This revision is now accepted and ready to land.May 11 2018, 22:09

Closed by commit rABCb2104e609c71: Use TxId in policyestimator_tests.cpp (authored by deadalnix). · Explain WhyMay 11 2018, 22:09

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

test/

policyestimator_tests.cpp

58 lines

Diff 3876

src/test/policyestimator_tests.cpp

Loading...