Page MenuHomePhabricator
Differential D1404

Use TxId internally in COutPoint
ClosedPublic
Actions

Authored by deadalnix on May 9 2018, 12:55.

Details

Reviewers
schancel
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGINGd4703235d636: Use TxId internally in COutPoint
rABCd4703235d636: Use TxId internally in COutPoint
Summary

This is a step toward improving type safety by using TxId/TxHash instead of raw uint256

Depends on D1403

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.May 9 2018, 12:55
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 9 2018, 12:55
teamcity added a subscriber: teamcity.May 9 2018, 12:55

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.May 9 2018, 13:16

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging failed.

Harbormaster failed remote builds in B2564: Diff 3850!May 9 2018, 13:16
deadalnix edited the summary of this revision. (Show Details)May 9 2018, 13:22
deadalnix added a parent revision: D1403: Make COutPoint's fields private.
jasonbcox added a subscriber: jasonbcox.May 9 2018, 20:49
jasonbcox added inline comments.
src/primitives/transaction.h
21 ↗(On Diff #3850)

The : uint256() is redundant

43 ↗(On Diff #3850)

Will the uint256 in the constructor be migrated later?

deadalnix added inline comments.May 11 2018, 22:40
src/primitives/transaction.h
43 ↗(On Diff #3850)

Yes, right now this crate a TON of compile errors.

schancel added a subscriber: schancel.May 12 2018, 03:00
schancel added inline comments.
src/primitives/transaction.h
43 ↗(On Diff #3850)

.png (338×669 px, 11 KB)

teamcity added a comment.May 14 2018, 23:45

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.May 15 2018, 00:08

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2564: Diff 3850.May 15 2018, 00:08
schancel accepted this revision.May 18 2018, 16:33
This revision is now accepted and ready to land.May 18 2018, 16:33
jasonbcox accepted this revision.May 20 2018, 23:23
Closed by commit rABCd4703235d636: Use TxId internally in COutPoint (authored by deadalnix). · Explain WhyMay 22 2018, 11:39
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
primitives/
10 lines

Diff 3924

View Options

src/primitives/transaction.h

Loading...