Page MenuHomePhabricator
Differential D13858

[Chronik] Add `/block-txs/:hash_or_height` HTTP endpoint
ClosedPublic
Actions

Authored by tobias_ruck on May 3 2023, 22:43.

Details

Reviewers
Fabien
PiRK
Group Reviewers
Restricted Project
Commits
rABCda07c06dda0b: [Chronik] Add `/block-txs/:hash_or_height` HTTP endpoint
Summary

Allows querying the txs of a block in paginated fashion.

The NNG Chronik returned these as part of the Block protobuf message, but it now is clear that this poses a DoS vector for larger blocks.

Depends on D13857.

Test Plan

ninja && ./test/functional/test_runner.py chronik_block_txs

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tobias_ruck created this revision.May 3 2023, 22:43
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 3 2023, 22:43
tobias_ruck requested review of this revision.May 3 2023, 22:43
Harbormaster completed remote builds in B23625: Diff 40183.May 3 2023, 22:55
tobias_ruck edited the summary of this revision. (Show Details)May 4 2023, 07:58
tobias_ruck added a parent revision: D13857: [Chronik] Refactor: Add `HashOrHeight` enum.
tobias_ruck updated this revision to Diff 40197.May 4 2023, 09:21

Rebase on chronik-refactor-hashorheight

Harbormaster completed remote builds in B23635: Diff 40197.May 4 2023, 10:00
PiRK added a subscriber: PiRK.May 4 2023, 10:06
PiRK added inline comments.
chronik/chronik-indexer/src/query/blocks.rs
88 ↗(On Diff #40197)
PiRK accepted this revision.May 4 2023, 12:29
This revision is now accepted and ready to land.May 4 2023, 12:29
Closed by commit rABCda07c06dda0b: [Chronik] Add `/block-txs/:hash_or_height` HTTP endpoint (authored by tobias_ruck). · Explain WhyMay 5 2023, 06:53
This revision was automatically updated to reflect the committed changes.
tobias_ruck added a commit: rABCda07c06dda0b: [Chronik] Add `/block-txs/:hash_or_height` HTTP endpoint.

Revision Contents
Changeset List

PathSize
chronik/
chronik-http/
src/
12 lines
13 lines
chronik-indexer/
src/
1 line
query/
119 lines
test/
functional/
257 lines
test_framework/
chronik/
31 lines

Diff 40207

View Options

chronik/chronik-http/src/handlers.rs

Loading...
View Options

chronik/chronik-http/src/server.rs

Loading...
View Options

chronik/chronik-indexer/src/indexer.rs

Loading...
View Options

chronik/chronik-indexer/src/query/blocks.rs

Loading...
View Options

test/functional/chronik_block_txs.py

Loading...
View Options

test/functional/test_framework/chronik/client.py

Loading...