Adding the content for the story section of the homepage.
Includes the paragraph and the video. The button will be added when that page is made
Details
Details
- Reviewers
bytesofman - Group Reviewers
Restricted Project - Commits
- rABCf909d928308a: [e.cash] Add story section content
@bot preview-e.cash
Check it looks good on both themes
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- ecash-story-section
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 23640 Build 46894: Build Diff Build 46893: arc lint + arc unit
Event Timeline
Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://54.39.104.128:41723 for the next 60 minutes.
Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://54.39.104.128:41513 for the next 60 minutes.
Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://54.39.104.128:41012 for the next 60 minutes.
Comment Actions
Rendering is good on my browser
| web/e.cash/pages/index.js | ||
|---|---|---|
| 90 | Is that needed ? AFAICT there is no fullscreen button outside of Youtube | |
| web/e.cash/pages/index.js | ||
|---|---|---|
| 70 | sure would be nice if this were <Container> | |
Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://54.39.19.73:41781 for the next 60 minutes.
Comment Actions
should be responsive to a min width of 320px
Right now, widths of < 400px are messed up
Comment Actions
should be responsive to a min width of 320px
Right now, widths of < 400px are messed up
hmm weird will check that out
| web/e.cash/pages/index.js | ||
|---|---|---|
| 90 | Yeah there is no button for it, but if you double click it goes full screen if this prop is there | |
| web/e.cash/pages/index.js | ||
|---|---|---|
| 70 | I was thinking the same thing! Thought it would be outside the scope of this diff though. Was planning to revisit the global CSS, as there are better ways to do it with styled components Ive seen | |
| web/e.cash/pages/index.js | ||
|---|---|---|
| 90 | TIL | |
Comment Actions
@bot preview-e.cash
| web/e.cash/pages/index.js | ||
|---|---|---|
| 70 | yeah doesn't need to be in this diff...could...be a task tho ;) | |
Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://51.178.130.230:41205 for the next 60 minutes.