Page MenuHomePhabricator

[e.cash] Add story section content
ClosedPublic

Authored by johnkuney on May 5 2023, 03:01.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Commits
rABCf909d928308a: [e.cash] Add story section content
Summary

Adding the content for the story section of the homepage.
Includes the paragraph and the video. The button will be added when that page is made

Test Plan

@bot preview-e.cash
Check it looks good on both themes

Diff Detail

Repository
rABC Bitcoin ABC
Branch
ecash-story-section
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 23640
Build 46894: Build Diff
Build 46893: arc lint + arc unit

Event Timeline

Rendering is good on my browser

web/e.cash/pages/index.js
90

Is that needed ? AFAICT there is no fullscreen button outside of Youtube

web/e.cash/pages/index.js
70

sure would be nice if this were <Container>

bytesofman requested changes to this revision.May 5 2023, 15:11

should be responsive to a min width of 320px

Right now, widths of < 400px are messed up

image.png (669×538 px, 233 KB)

image.png (859×538 px, 157 KB)

This revision now requires changes to proceed.May 5 2023, 15:11

should be responsive to a min width of 320px

Right now, widths of < 400px are messed up

image.png (669×538 px, 233 KB)

image.png (859×538 px, 157 KB)

hmm weird will check that out

web/e.cash/pages/index.js
90

Yeah there is no button for it, but if you double click it goes full screen if this prop is there

web/e.cash/pages/index.js
70

I was thinking the same thing! Thought it would be outside the scope of this diff though. Was planning to revisit the global CSS, as there are better ways to do it with styled components Ive seen

web/e.cash/pages/index.js
90

TIL

@bot preview-e.cash

web/e.cash/pages/index.js
70

yeah doesn't need to be in this diff...could...be a task tho ;)

This revision is now accepted and ready to land.May 5 2023, 17:55
This revision was automatically updated to reflect the committed changes.