[lint] replace autopep8 with black (everything but contrib)
ClosedPublic
Actions

Authored by PiRK on May 11 2023, 08:01.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCa8686ab06c8d: [lint] replace autopep8 with black (everything but contrib)

Summary

Run black on all files previously linted by autopep8, excluding "contrib" (will be split over more diffs for ease of review).
See D13876 for more background on black.

Note that this also touches some files previously processed in D13879, D13880 and D13881. This is because I did not rerun the linter after landing D13882, so already submitted diffs did not apply a few of the --preview related changes.

Depends on D13888

Test Plan

With chronik enabled: ninja all check-all
arc lint --everything

CI builds

Diff Detail

Repository

rABC Bitcoin ABC

Branch

autopep8_to_black

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 23693
Build 47000: Build Diff	lint-circular-dependencies · build-without-wallet · build-fuzzer · build-diff · build-debug · build-clang-tidy · build-clang
Build 46999: arc lint + arc unit

Event Timeline

PiRK created this revision.May 11 2023, 08:01

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 11 2023, 08:01

PiRK requested review of this revision.May 11 2023, 08:01

PiRK edited the test plan for this revision. (Show Details)May 11 2023, 08:07

PiRK added inline comments.May 11 2023, 08:09

.arclint
36	The first two excludes will be kept in following diffs, as they were already applied to autopep8.

convert a string concatenation to a f-string to fit on a single line in bitcoin-util-test.py

Harbormaster completed remote builds in B23693: Diff 40278.May 11 2023, 08:24

Harbormaster completed remote builds in B23694: Diff 40279.May 11 2023, 08:33

Fabien requested changes to this revision.May 12 2023, 08:16

Fabien added a subscriber: Fabien.

Fabien added inline comments.

.arclint
22 ↗	(On Diff #40279)	You still need to exclude "(^contrib/gitian-builder/)" and "(^contrib/apple-sdk-tools/)", otherwise you're appying autopep8 on those files with your change