Page MenuHomePhabricator

[lint] replace autopep8 with black (everything but contrib)

Authored by PiRK on Thu, May 11, 08:01.



Run black on all files previously linted by autopep8, excluding "contrib" (will be split over more diffs for ease of review).
See D13876 for more background on black.

Note that this also touches some files previously processed in D13879, D13880 and D13881. This is because I did not rerun the linter after landing D13882, so already submitted diffs did not apply a few of the --preview related changes.

Depends on D13888

Test Plan

With chronik enabled: ninja all check-all
arc lint --everything

CI builds

Diff Detail

rABC Bitcoin ABC
Lint Not Applicable
Tests Not Applicable

Event Timeline

PiRK requested review of this revision.Thu, May 11, 08:01
36 ↗(On Diff #40278)

The first two excludes will be kept in following diffs, as they were already applied to autopep8.

convert a string concatenation to a f-string to fit on a single line in

Fabien requested changes to this revision.Fri, May 12, 08:16
Fabien added a subscriber: Fabien.
Fabien added inline comments.
22 ↗(On Diff #40279)

You still need to exclude "(^contrib/gitian-builder/)" and "(^contrib/apple-sdk-tools/)", otherwise you're appying autopep8 on those files with your change

This revision now requires changes to proceed.Fri, May 12, 08:16

add back the excludes for autopep8

This revision is now accepted and ready to land.Fri, May 12, 13:27