Page MenuHomePhabricator

[e.cash] Add footer to layout
ClosedPublic

Authored by johnkuney on May 16 2023, 16:34.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Commits
rABC3e3fffc21684: [e.cash] Add footer to layout
Summary

Adding the footer to the layout component. It uses the same link data for the navbar to render footer links, along with social links and contact email

Test Plan

@bot preview-e.cash
-scroll to bottom of the page to view the footer
-check everything looks good on mobile and both themes
-check links work

Diff Detail

Repository
rABC Bitcoin ABC
Branch
ecash-footer
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 23740
Build 47090: Build Diff
Build 47089: arc lint + arc unit

Event Timeline

bytesofman added inline comments.
web/e.cash/components/footer/index.js
75–80 ↗(On Diff #40329)

Seems like we will want to have a Link component that opens external links in a new tab and internal links in the current window to use everywhere in the app.

Make this as its own component, say CustomLink, so we don't need to repeat this logic everywhere else.

This revision now requires changes to proceed.May 16 2023, 17:28

create custom link component to avoid reproducing target blank logic

bytesofman added inline comments.
web/e.cash/components/custom-link/index.js
3–13 ↗(On Diff #40330)

simplify with

export const CustomLink = ({ href, children }) => {
    return href.startsWith('https') ? (
        <Link href={href} target="_blank" rel="noreferrer">
            {children}
        </Link>
    ) : (
        <Link href={href}>{children}</Link>
    );
};
This revision now requires changes to proceed.May 17 2023, 16:47

image.png (606×949 px, 37 KB)

At resolutions < 920px, the navbar logo clashes with the footer logo

Since the navbar logo carries down with the page, best solution is probably to just hide the footer logo for this resolution. Open to alt solutions though.

This revision now requires changes to proceed.May 17 2023, 21:45

At resolutions < 920px, the navbar logo clashes with the footer logo

Since the navbar logo carries down with the page, best solution is probably to just hide the footer logo for this resolution. Open to alt solutions though.

Well it will be less severe once its merged with the latest that has the navbar background added back in. But there will still be some clashing as the nav background is translucent, as seen in the current site. I can remove at smaller screens though, as it is a bit logo overkill

hide logo on smaller screens

At resolutions < 920px, the navbar logo clashes with the footer logo

Since the navbar logo carries down with the page, best solution is probably to just hide the footer logo for this resolution. Open to alt solutions though.

Well it will be less severe once its merged with the latest that has the navbar background added back in. But there will still be some clashing as the nav background is translucent, as seen in the current site. I can remove at smaller screens though, as it is a bit logo overkill

In this case, you should rebase this diff on top of the other one after it's landed

bytesofman added inline comments.
web/e.cash/components/footer/styles.js
37–38 ↗(On Diff #40346)

revert this, looks better with the fix from the other navbar diff. looks bad with the logo gone.

This revision now requires changes to proceed.May 17 2023, 23:55
This revision is now accepted and ready to land.May 18 2023, 12:25
This revision was automatically updated to reflect the committed changes.