Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC3e3fffc21684: [e.cash] Add footer to layout

Summary

Adding the footer to the layout component. It uses the same link data for the navbar to render footer links, along with social links and contact email

Test Plan

@bot preview-e.cash
-scroll to bottom of the page to view the footer
-check everything looks good on mobile and both themes
-check links work

Diff Detail

Repository

rABC Bitcoin ABC

Branch

ecash-footer

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 23741
Build 47092: Build Diff
Build 47091: arc lint + arc unit

Event Timeline

johnkuney created this revision.May 16 2023, 16:34

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 16 2023, 16:34

johnkuney requested review of this revision.May 16 2023, 16:34

Harbormaster completed remote builds in B23725: Diff 40329.May 16 2023, 16:34

@bot preview-e.cash

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://54.39.19.73:41722 for the next 60 minutes.

bytesofman requested changes to this revision.May 16 2023, 17:28

bytesofman added inline comments.

web/e.cash/components/footer/index.js
75–80 ↗	(On Diff #40329)	Seems like we will want to have a Link component that opens external links in a new tab and internal links in the current window to use everywhere in the app. Make this as its own component, say `CustomLink`, so we don't need to repeat this logic everywhere else.

This revision now requires changes to proceed.May 16 2023, 17:28

create custom link component to avoid reproducing target blank logic

Harbormaster completed remote builds in B23726: Diff 40330.May 16 2023, 19:21

@bot preview-e.cash

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://51.178.130.230:41932 for the next 60 minutes.

bytesofman requested changes to this revision.May 17 2023, 16:47

bytesofman added inline comments.

web/e.cash/components/custom-link/index.js

3–13 ↗

(On Diff #40330)

simplify with

export const CustomLink = ({ href, children }) => {
    return href.startsWith('https') ? (
        <Link href={href} target="_blank" rel="noreferrer">
            {children}
        </Link>
    ) : (
        <Link href={href}>{children}</Link>
    );
};

This revision now requires changes to proceed.May 17 2023, 16:47

simplify custom link

Harbormaster completed remote builds in B23733: Diff 40345.May 17 2023, 20:49

@bot preview-e.cash

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://54.39.19.73:41838 for the next 60 minutes.

At resolutions < 920px, the navbar logo clashes with the footer logo

Since the navbar logo carries down with the page, best solution is probably to just hide the footer logo for this resolution. Open to alt solutions though.

This revision now requires changes to proceed.May 17 2023, 21:45

At resolutions < 920px, the navbar logo clashes with the footer logo

Since the navbar logo carries down with the page, best solution is probably to just hide the footer logo for this resolution. Open to alt solutions though.

Well it will be less severe once its merged with the latest that has the navbar background added back in. But there will still be some clashing as the nav background is translucent, as seen in the current site. I can remove at smaller screens though, as it is a bit logo overkill

hide logo on smaller screens

Harbormaster completed remote builds in B23734: Diff 40346.May 17 2023, 22:30

In D13908#310265, @johnkuney wrote:

At resolutions < 920px, the navbar logo clashes with the footer logo

Since the navbar logo carries down with the page, best solution is probably to just hide the footer logo for this resolution. Open to alt solutions though.

Well it will be less severe once its merged with the latest that has the navbar background added back in. But there will still be some clashing as the nav background is translucent, as seen in the current site. I can remove at smaller screens though, as it is a bit logo overkill

In this case, you should rebase this diff on top of the other one after it's landed

@bot preview-e.cash

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://54.39.19.73:41646 for the next 60 minutes.

bytesofman requested changes to this revision.May 17 2023, 23:55

bytesofman added inline comments.