Differential D13932

depends: Do not force Precompiled Headers (PCH) for building Qt on Linux
ClosedPublic
Actions

Authored by PiRK on May 25 2023, 09:36.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC3fb9fb71635d: depends: Do not force Precompiled Headers (PCH) for building Qt on Linux

Summary

On CentOS 8 the forced '-pch' option breaks Qt build.
Removing '-pch' option does not affect build time for other Linux
systems.

This is a backport of core#20520

Test Plan

gitian builds, local crossbuild

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.May 25 2023, 09:36

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 25 2023, 09:36

PiRK requested review of this revision.May 25 2023, 09:36

teamcity edited the summary of this revision. (Show Details)May 25 2023, 09:36

Harbormaster completed remote builds in B23787: Diff 40419.May 25 2023, 09:36

@bot gitian-osx gitian-linux gitian-win

teamcity awarded a token.May 25 2023, 09:37

PiRK added a child revision: D13933: Add depends qt fix for ARM macs.May 25 2023, 09:41

Fabien accepted this revision.May 25 2023, 12:39

This revision is now accepted and ready to land.May 25 2023, 12:39

Closed by commit rABC3fb9fb71635d: depends: Do not force Precompiled Headers (PCH) for building Qt on Linux (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>, committed by PiRK). · Explain WhyMay 25 2023, 13:13

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC3fb9fb71635d: depends: Do not force Precompiled Headers (PCH) for building Qt on Linux.

Revision Contents
Changeset List

Path

Size

depends/

packages/

qt.mk

3 lines

Diff 40425

View Options

depends: Do not force Precompiled Headers (PCH) for building Qt on LinuxClosedPublicActions