Differential D13935

build: patch qt to explicitly define previously implicit header include
ClosedPublic
Actions

Authored by PiRK on May 25 2023, 10:36.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC8f6b8b43b940: build: patch qt to explicitly define previously implicit header include

Summary

macOS Monterey has refactored some includes such that implicitly defined headers were no longer exposed and that in turns breaks building Qt on macOS 12.

Additional Resources:

This is a backport of core#23580
Depends on D13934

Test Plan

gitian-osx

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.May 25 2023, 10:36

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 25 2023, 10:36

PiRK requested review of this revision.May 25 2023, 10:36

teamcity edited the summary of this revision. (Show Details)May 25 2023, 10:36

Harbormaster completed remote builds in B23791: Diff 40423.May 25 2023, 10:36

@bot gitian-osx

teamcity awarded a token.May 25 2023, 10:37

Fabien accepted this revision.May 25 2023, 12:41

Fabien added a subscriber: Fabien.

Fabien added inline comments.

depends/packages/qt.mk
16 ↗	(On Diff #40423)	So bad that core did that typo

This revision is now accepted and ready to land.May 25 2023, 12:41

Closed by commit rABC8f6b8b43b940: build: patch qt to explicitly define previously implicit header include (authored by Kittywhiskers Van Gogh <63189531+kittywhiskers@users.noreply.github.com>, committed by PiRK). · Explain WhyMay 25 2023, 13:13

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC8f6b8b43b940: build: patch qt to explicitly define previously implicit header include.

Revision Contents
Changeset List

Path

Size

depends/

packages/

qt.mk

2 lines

patches/

qt/

fix_montery_include.patch

21 lines

Diff 40427

View Options

depends/packages/qt.mk