Page MenuHomePhabricator
Differential D14039

Fix arm64 darwin package def for OpenSSl
ClosedPublic
Actions

Authored by PiRK on Jun 12 2023, 08:36.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCcbbea03edf54: Fix arm64 darwin package def for OpenSSl
Summary

Backport of https://github.com/monero-project/monero/commit/fe5c2aec35970c545f50679a06d9231b13104c5a

Test Plan
cd depends
HOST="arm64-apple-darwin" make openssl

This now successfuly compiles OpenSSL.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr27312
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 24032
Build 47674: Build Diff
Build 47673: arc lint + arc unit

Event Timeline

PiRK created this revision.Jun 12 2023, 08:36
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 12 2023, 08:36
PiRK requested review of this revision.Jun 12 2023, 08:36
Harbormaster completed remote builds in B23993: Diff 40723.Jun 12 2023, 08:37
PiRK mentioned this in D14016: gitian: support arm64 darwin.Jun 12 2023, 08:38
PiRK added a child revision: D14040: [depends] Use more recent config.guess and config.sub in various packages.Jun 12 2023, 09:09
Fabien requested changes to this revision.Jun 12 2023, 12:22
Fabien added a subscriber: Fabien.

The test plan doesn't really help to know if this is enough. You should run:

cd depends
HOSTS="arm64-apple-darwin" make openssl

And check the libs are built for the correct target

This revision now requires changes to proceed.Jun 12 2023, 12:22
PiRK mentioned this in D14040: [depends] Use more recent config.guess and config.sub in various packages.Jun 13 2023, 08:44
PiRK updated this revision to Diff 40778.Jun 14 2023, 06:43
PiRK edited the test plan for this revision. (Show Details)

rebase and update test plan. guix and gitian are still missing a toolchain file for ARM64 darwin, so just crosscompile the one library.

Harbormaster completed remote builds in B24032: Diff 40778.Jun 14 2023, 06:43
Fabien accepted this revision.Jun 14 2023, 12:33
This revision is now accepted and ready to land.Jun 14 2023, 12:33
Closed by commit rABCcbbea03edf54: Fix arm64 darwin package def for OpenSSl (authored by Howard Chu <hyc@symas.com>, committed by PiRK). · Explain WhyJun 14 2023, 14:50
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCcbbea03edf54: Fix arm64 darwin package def for OpenSSl.

Revision Contents
Changeset List

PathSize
depends/
packages/
1 line

Diff 40778

View Options

depends/packages/openssl.mk

Loading...