Page MenuHomePhabricator

Activate wellington by block height
ClosedPublic

Authored by Fabien on Jun 13 2023, 18:45.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABCa830636a4a5c: Activate wellington by block height
Summary

Now that the activation is in the past, we can use the activation block height instead of the MTP.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien requested review of this revision.Jun 13 2023, 18:45

Tail of the build log:

chronik_ws_script.py                      | ○ Skipped | 0 s
interface_usdt_net.py                     | ○ Skipped | 0 s
interface_usdt_utxocache.py               | ○ Skipped | 0 s
interface_usdt_validation.py              | ○ Skipped | 0 s

ALL                                       | ✓ Passed  | 1304 s (accumulated) 
Runtime: 261 s

[265/833] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/script_tests.cpp.o
In file included from /usr/include/boost/test/unit_test.hpp:19,
                 from ../../src/test/script_tests.cpp:30:
../../src/test/script_tests.cpp: In member function ‘void script_tests::script_build::test_method()’:
../../src/test/script_tests.cpp:540:22: note: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’, retrying without
  540 | BOOST_AUTO_TEST_CASE(script_build) {
      |                      ^~~~~~~~~~~~
[267/833] cd /work/contrib/devtools/chainparams && /usr/bin/python3.9 ./test_make_chainparams.py
.....
----------------------------------------------------------------------
Ran 5 tests in 0.001s

OK
[803/833] Running pow test suite
PASSED: pow test suite
[806/833] Running bitcoin test suite
PASSED: bitcoin test suite
[810/833] Running seeder test suite
PASSED: seeder test suite
[822/833] Running bitcoin-upgrade-activated test suite
PASSED: bitcoin-upgrade-activated test suite
[824/833] Running bitcoin-qt test suite
PASSED: bitcoin-qt test suite
[831/833] Running avalanche test suite
PASSED: avalanche test suite
[832/833] Running functional tests with the next upgrade activated
Starting Bitcoin ABC functional tests with the next upgrade activated
Temporary test directory at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_🏃_20230613_185558
.........
----------------------------------------------------------------------
Ran 9 tests in 0.076s

OK
usage: create_cache.py [options]
create_cache.py: error: unrecognized arguments: --with-wellingtonactivation
Running Unit Tests for Test Framework Modules
Traceback (most recent call last):
  File "/work/abc-ci-builds/build-diff/test/./functional/test_runner.py", line 1062, in <module>
    main()
  File "/work/abc-ci-builds/build-diff/test/./functional/test_runner.py", line 455, in main
    run_tests(
  File "/work/abc-ci-builds/build-diff/test/./functional/test_runner.py", line 538, in run_tests
    subprocess.check_output(
  File "/usr/lib/python3.9/subprocess.py", line 424, in check_output
    return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
  File "/usr/lib/python3.9/subprocess.py", line 528, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['/usr/bin/python3.9', '/work/test/functional/create_cache.py', '--cachedir=/work/abc-ci-builds/build-diff/test/cache', '--with-wellingtonactivation', '--configfile=/work/abc-ci-builds/build-diff/test/functional/../config.ini', '--tmpdir=/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_🏃_20230613_185558/cache']' returned non-zero exit status 2.
FAILED: test/CMakeFiles/check-functional-upgrade-activated 
cd /work/abc-ci-builds/build-diff/test && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-diff/test/junit && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-diff/test/log && /usr/bin/cmake -E env /usr/bin/python3.9 ./functional/test_runner.py "--testsuitename=Bitcoin ABC functional tests with the next upgrade activated" --junitoutput=/work/abc-ci-builds/build-diff/test/junit/functional_tests_with_the_next_upgrade_activated.xml --with-wellingtonactivation
ninja: build stopped: cannot make progress due to previous errors.
Build build-diff failed with exit code 1
PiRK requested changes to this revision.Jun 14 2023, 06:18
PiRK added a subscriber: PiRK.

There are two more --with-wellingtonactivation in test/CMakeLists.txt

This revision now requires changes to proceed.Jun 14 2023, 06:18

Fix unit tests with upgrade activated

This revision is now accepted and ready to land.Jun 16 2023, 16:29
This revision was automatically updated to reflect the committed changes.