Page MenuHomePhabricator
Differential D14086

[alias-server] Update aliasConstants import in index.js
ClosedPublic
Actions

Authored by bytesofman on Jun 19 2023, 23:11.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABC60ebb807f2d9: [alias-server] Update aliasConstants import in index.js
Summary

T3060

Correct import for aliasConstants

Test Plan

npm test

node index.js and app boots up locally

Diff Detail

Repository
rABC Bitcoin ABC
Branch
alias-server-prod-patches
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 24104
Build 47818: Build Diffalias-server-tests
Build 47817: arc lint + arc unit

Event Timeline

bytesofman created this revision.Jun 19 2023, 23:11
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 19 2023, 23:11
bytesofman requested review of this revision.Jun 19 2023, 23:11
bytesofman edited the test plan for this revision. (Show Details)Jun 19 2023, 23:12
Harbormaster completed remote builds in B24104: Diff 40882.Jun 19 2023, 23:36
emack requested changes to this revision.Jun 19 2023, 23:56
emack added a subscriber: emack.

image.png (308×1 px, 54 KB)

2 tests failing for me

Also on app startup it seems to timeout when calling isFinalBlock. I've pointed it at my avalanche node and manual curls work fine but not through this app.

image.png (651×1 px, 155 KB)

This revision now requires changes to proceed.Jun 19 2023, 23:56
emack added a comment.Jun 19 2023, 23:58

FYI - in secrets.js the rpc port is specified as part of avalancheRpc.url. Let me know if it shouldn't be in there.

bytesofman added a comment.Jun 20 2023, 00:04
In D14086#314676, @emack wrote:

FYI - in secrets.js the rpc port is specified as part of avalancheRpc.url. Let me know if it shouldn't be in there.

it's the default so ok to be there

bytesofman added a comment.Jun 20 2023, 00:06
In D14086#314673, @emack wrote:

image.png (308×1 px, 54 KB)

2 tests failing for me

Also on app startup it seems to timeout when calling isFinalBlock. I've pointed it at my avalanche node and manual curls work fine but not through this app.

image.png (651×1 px, 155 KB)

check node version for the unit tests, they are passing on my machine and CI

does curl work with isFinalBlock ?

emack added a comment.EditedJun 20 2023, 00:18

node version is v16.20.0

edit: ok I think I've worked out why - the app's index.js is looking for ./secrets whereas mainTests.js is looking for ../secrets.sample

bytesofman requested review of this revision.Jun 20 2023, 12:42
In D14086#314683, @emack wrote:

node version is v16.20.0

edit: ok I think I've worked out why - the app's index.js is looking for ./secrets whereas mainTests.js is looking for ../secrets.sample

ok yeah. taking a look at the README, there's a lot of updating and documentation that needs to be changed. I'll do this in a separate diff. For now,

cp secrets.sample.js secrets.js

then update with your parameters and node index.js

emack accepted this revision.Jun 20 2023, 13:16
This revision is now accepted and ready to land.Jun 20 2023, 13:16
Closed by commit rABC60ebb807f2d9: [alias-server] Update aliasConstants import in index.js (authored by bytesofman). · Explain WhyJun 20 2023, 16:10
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC60ebb807f2d9: [alias-server] Update aliasConstants import in index.js.

Revision Contents
Changeset List

PathSize
apps/
alias-server/
3 lines

Diff 40882

View Options

apps/alias-server/index.js

Loading...