Differential D14091

refactor: introduce single-separator split helper `SplitString`
ClosedPublic
Actions

Authored by Fabien on Jun 20 2023, 20:18.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC8e3a86171fd6: refactor: introduce single-separator split helper `SplitString`

Summary

This helper uses spanparsing::Split internally and enables to replace
all calls to boost::split where only a single separator is passed.

Backport of core#22953.

Test Plan

ninja all check-all
ninja bitcoin-fuzzers

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Jun 20 2023, 20:18

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 20 2023, 20:18

Fabien requested review of this revision.Jun 20 2023, 20:18

teamcity edited the summary of this revision. (Show Details)Jun 20 2023, 20:18

Harbormaster completed remote builds in B24116: Diff 40903.Jun 20 2023, 20:34

PiRK accepted this revision.Jun 21 2023, 07:11

This revision is now accepted and ready to land.Jun 21 2023, 07:11

Closed by commit rABC8e3a86171fd6: refactor: introduce single-separator split helper `SplitString` (authored by Sebastian Falbesoner <sebastian.falbesoner@gmail.com>, committed by Fabien). · Explain WhyJun 21 2023, 13:22

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC8e3a86171fd6: refactor: introduce single-separator split helper `SplitString`.

Revision Contents
Changeset List

Path

Size

src/

bitcoin-tx.cpp

17 lines

rest.cpp

7 lines

rpc/

server.cpp

7 lines

util.cpp

8 lines

test/

fuzz/

string.cpp

2 lines

util_tests.cpp

48 lines

torcontrol.cpp

6 lines

util/

spanparsing.h

16 lines

spanparsing.cpp

15 lines

string.h

8 lines

wallet/

rpc/

backup.cpp

5 lines

Diff 40909

View Options

src/bitcoin-tx.cpp

View Options

src/rest.cpp

View Options

src/rpc/server.cpp

View Options

src/rpc/util.cpp

View Options

src/test/fuzz/string.cpp

View Options

src/test/util_tests.cpp

View Options

src/torcontrol.cpp

View Options

src/util/spanparsing.h

View Options

src/util/spanparsing.cpp

View Options

src/util/string.h

View Options

refactor: introduce single-separator split helper `SplitString`ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 40909

src/bitcoin-tx.cpp

src/rest.cpp

src/rpc/server.cpp

src/rpc/util.cpp

src/test/fuzz/string.cpp

src/test/util_tests.cpp

src/torcontrol.cpp

src/util/spanparsing.h

src/util/spanparsing.cpp

src/util/string.h

src/wallet/rpc/backup.cpp

refactor: introduce single-separator split helper `SplitString`
ClosedPublic
Actions

Revision Contents
Changeset List