Page MenuHomePhabricator

[ecash-herald] Support for configurable emojis in msgs
ClosedPublic

Authored by bytesofman on Jun 20 2023, 20:39.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABC057077b21639: [ecash-herald] Support for configurable emojis in msgs
Summary

T2972

Add emojis to msg in a configurable panel

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emack requested changes to this revision.Jun 21 2023, 00:44
emack added a subscriber: emack.
emack added inline comments.
apps/ecash-herald/src/parse.js
1100 ↗(On Diff #40905)

for both unencrypted and encrypted messaging transactions you're also sending XEC along with it, sometimes for a nominal amount, other times for a material amount. would it make sense to have both xecSend and the msg emojis?

This revision now requires changes to proceed.Jun 21 2023, 00:44
bytesofman added inline comments.
apps/ecash-herald/src/parse.js
1100 ↗(On Diff #40905)

Would be an improvement, but unrelated to this diff. Task open T3200

This revision is now accepted and ready to land.Jun 21 2023, 06:03