Page MenuHomePhabricator
Differential D14092

[ecash-herald] Support for configurable emojis in msgs
ClosedPublic
Actions

Authored by bytesofman on Jun 20 2023, 20:39.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABC057077b21639: [ecash-herald] Support for configurable emojis in msgs
Summary

T2972

Add emojis to msg in a configurable panel

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
ecash-herald-emojis
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 24117
Build 47844: Build Diffecash-herald-tests
Build 47843: arc lint + arc unit

Event Timeline

bytesofman created this revision.Jun 20 2023, 20:39
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 20 2023, 20:39
bytesofman requested review of this revision.Jun 20 2023, 20:39
Harbormaster completed remote builds in B24117: Diff 40905.Jun 20 2023, 20:48
emack requested changes to this revision.Jun 21 2023, 00:44
emack added a subscriber: emack.
emack added inline comments.
apps/ecash-herald/src/parse.js
1100

for both unencrypted and encrypted messaging transactions you're also sending XEC along with it, sometimes for a nominal amount, other times for a material amount. would it make sense to have both xecSend and the msg emojis?

This revision now requires changes to proceed.Jun 21 2023, 00:44
bytesofman requested review of this revision.Jun 21 2023, 04:29
bytesofman added inline comments.
apps/ecash-herald/src/parse.js
1100

Would be an improvement, but unrelated to this diff. Task open T3200

emack accepted this revision.Jun 21 2023, 06:03
This revision is now accepted and ready to land.Jun 21 2023, 06:03
Closed by commit rABC057077b21639: [ecash-herald] Support for configurable emojis in msgs (authored by bytesofman). · Explain WhyJun 21 2023, 12:39
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC057077b21639: [ecash-herald] Support for configurable emojis in msgs.

Revision Contents
Changeset List

PathSize
apps/
ecash-herald/
14 lines
src/
39 lines
test/
mocks/

Diff 40905

View Options

apps/ecash-herald/config.js

Loading...
View Options

apps/ecash-herald/src/parse.js

Loading...
View Options

apps/ecash-herald/test/mocks/blocks.js

Loading...