Page MenuHomePhabricator
Differential D14099

[ecash-herald] Label addresses with emoji based on balance
ClosedPublic
Actions

Authored by bytesofman on Jun 21 2023, 22:18.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC7ccd5edc3c18: [ecash-herald] Label addresses with emoji based on balance
Summary

T2972

Add logic to the app to get balance information of addresses before msg is generated. This allows tagging addresses with creature emojis depending on their wealth.

Requires a good deal of support and helper functions to get to this feature.

  • mocked chronik had to be upgraded to support chronik.script.utxos()
  • Need to save the responses from chronik.script.utxos() to mocks to be able to do unit tests with these mocks
  • Add emojis and balance thresholds to config
Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
whale-watch
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 24189
Build 47988: Build Diffecash-herald-tests
Build 47987: arc lint + arc unit

Event Timeline

bytesofman created this revision.Jun 21 2023, 22:18
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 21 2023, 22:18
bytesofman requested review of this revision.Jun 21 2023, 22:18
Harbormaster completed remote builds in B24125: Diff 40918.Jun 21 2023, 22:20
bytesofman planned changes to this revision.Jun 21 2023, 22:21

Note: blocks.js goes from less than 1MB to over 30MB by including all the utxos

Mocking all of these chronik calls ... is probably overkill.

Or, having so many test blocks is overkill. If we don't mock the utxos, then we are hand waving a lot of app logic.

bytesofman mentioned this in D14114: [ecash-herald] Reduce test blocks.Jun 23 2023, 17:05
bytesofman mentioned this in rABCa3b2ea986c0b: [ecash-herald] Reduce test blocks.Jun 24 2023, 19:40
bytesofman updated this revision to Diff 40970.Jun 24 2023, 19:42

rebase with smaller mocks file

bytesofman planned changes to this revision.Jun 24 2023, 19:43

Removing most of the blocks didn't really reduce the size of the mocks by too much (30+ mb down to 23 mb)

will cut out some more blocks. depends on block having an address with many utxos.

Harbormaster completed remote builds in B24161: Diff 40970.Jun 24 2023, 19:59
bytesofman updated this revision to Diff 41006.Jun 26 2023, 19:37

only get output scripts of rendered outputs

Harbormaster completed remote builds in B24187: Diff 41006.Jun 26 2023, 19:38
bytesofman updated this revision to Diff 41007.Jun 26 2023, 19:38

lint

Harbormaster completed remote builds in B24188: Diff 41007.Jun 26 2023, 19:40
bytesofman updated this revision to Diff 41008.Jun 26 2023, 19:45

Adjust set of test blocks to remove the largest by size

Harbormaster completed remote builds in B24189: Diff 41008.Jun 26 2023, 19:46
bytesofman updated this revision to Diff 41009.Jun 26 2023, 19:54

remove incidental formatting changes unrelated to this diff

bytesofman retitled this revision from [ecash-herald] Label addresses with em emoji based on balance to [ecash-herald] Label addresses with emoji based on balance.Jun 26 2023, 19:55
Harbormaster completed remote builds in B24190: Diff 41009.Jun 26 2023, 19:55
bytesofman updated this revision to Diff 41038.Jun 27 2023, 17:42

Do not hide generateMocks.js

Harbormaster completed remote builds in B24209: Diff 41038.Jun 27 2023, 17:44
Fabien requested changes to this revision.Jun 27 2023, 18:12
Fabien added a subscriber: Fabien.
Fabien added inline comments.
apps/ecash-herald/src/chronik.js
55 ↗(On Diff #41009)

Remove or format properly so it doesn't look like it's a debug string.

apps/ecash-herald/src/parse.js
75 ↗(On Diff #41009)

You don't need the else

apps/ecash-herald/src/utils.js
329 ↗(On Diff #41009)

Use a ternary and make balanceSats a const

346 ↗(On Diff #41009)

Might not be worth moving in another file, just put it where it's called

362 ↗(On Diff #41009)

That's unusual to me

This revision now requires changes to proceed.Jun 27 2023, 18:12
bytesofman marked 5 inline comments as done.Jun 27 2023, 21:43
bytesofman updated this revision to Diff 41046.Jun 27 2023, 21:43

Responding to feedback

Harbormaster completed remote builds in B24215: Diff 41046.Jun 27 2023, 21:43
bytesofman updated this revision to Diff 41047.Jun 27 2023, 21:45

lint, add comments explaining generated var change

Harbormaster completed remote builds in B24216: Diff 41047.Jun 27 2023, 21:46
bytesofman updated this revision to Diff 41048.Jun 27 2023, 22:01

Remove debug logging

bytesofman updated this revision to Diff 41049.Jun 27 2023, 22:02

remove more debug logging

Harbormaster completed remote builds in B24217: Diff 41048.Jun 27 2023, 22:03
Harbormaster completed remote builds in B24218: Diff 41049.
bytesofman added a child revision: D14140: [ecash-herald] Remove one-off promise building function from utils and add to its parent function.Jun 27 2023, 22:05
Fabien requested changes to this revision.Jun 28 2023, 07:12
Fabien added inline comments.
apps/ecash-herald/src/utils.js
315 ↗(On Diff #41049)

You don't need any else

This revision now requires changes to proceed.Jun 28 2023, 07:12
bytesofman updated this revision to Diff 41069.Jun 28 2023, 13:07

Remove useless elses, add docs to function

bytesofman marked an inline comment as done.Jun 28 2023, 13:07
Harbormaster completed remote builds in B24230: Diff 41069.Jun 28 2023, 13:08
Fabien accepted this revision.Jun 28 2023, 17:03
This revision is now accepted and ready to land.Jun 28 2023, 17:03
Closed by commit rABC7ccd5edc3c18: [ecash-herald] Label addresses with emoji based on balance (authored by bytesofman). · Explain WhyJun 28 2023, 17:13
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC7ccd5edc3c18: [ecash-herald] Label addresses with emoji based on balance.

Revision Contents
Changeset List

PathSize
apps/
ecash-herald/
30 lines
scripts/
src/
36 lines
11 lines
93 lines
72 lines
test/
11 lines
12 lines
mocks/
22 lines
8 lines
12 lines

Diff 41008

View Options

apps/ecash-herald/config.js

Loading...
View Options

apps/ecash-herald/scripts/generateMocks.js

Loading...
View Options

apps/ecash-herald/src/chronik.js

Loading...
View Options

apps/ecash-herald/src/events.js

Loading...
View Options

apps/ecash-herald/src/parse.js

Loading...
View Options

apps/ecash-herald/src/utils.js

Loading...
View Options

apps/ecash-herald/test/chronikWsHandlerTests.js

Loading...
View Options

apps/ecash-herald/test/eventsTests.js

Loading...
View Options

apps/ecash-herald/test/mocks/blocks.js

Loading...
View Options

apps/ecash-herald/test/mocks/chronikMock.js

Loading...
View Options

apps/ecash-herald/test/parseTests.js

Loading...
View Options

apps/ecash-herald/test/utilsTests.js

Loading...