[Cashtab] Move parseAddressForParams out of Ticker.js
ClosedPublic
Actions

Authored by emack on Jun 24 2023, 13:19.

Details

Reviewers

bytesofman
Fabien

Group Reviewers

Restricted Project

Commits

rABCa964bee610b3: [Cashtab] Move parseAddressForParams out of Ticker.js

Summary

Similar to D14102, this diff moves the parseAddressForParams function out of Ticker.js and into cashMethods.

Test Plan

grep -r parseAddressForParams src/ and ensure all import statements are referring to cashMethods.js rather than Ticker.js
npm test
npm start
regression test scanning of a valid and invalid QR code for address (use https://d14115.netlify.app/ on phone)
regression test signing and verifying signatures
regression test sending a token to an ecash address
regression test sending XEC to an ecash address

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emack created this revision.Jun 24 2023, 13:19

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 24 2023, 13:19

emack requested review of this revision.Jun 24 2023, 13:19

Harbormaster completed remote builds in B24160: Diff 40967.Jun 24 2023, 13:22

This function is moved, and still there is no test change. This is an evidence that a unit test is missing.
Add these tests first then move the code, so the reviewer can be confident that there is no subtle change happening during the move because the test keeps passing.

This revision now requires changes to proceed.Jun 24 2023, 15:26

emack mentioned this in D14117: [Cashtab] Add unit tests for parseAddressForParams.Jun 25 2023, 01:52

emack mentioned this in rABC3d98363bce0e: [Cashtab] Add unit tests for parseAddressForParams.Jun 26 2023, 07:31

emack edited the test plan for this revision. (Show Details)Jun 26 2023, 08:02