Similar to D14102, this diff moves the parseAddressForParams function out of Ticker.js and into cashMethods.
Details
Details
- Reviewers
bytesofman Fabien - Group Reviewers
Restricted Project - Commits
- rABCa964bee610b3: [Cashtab] Move parseAddressForParams out of Ticker.js
- grep -r parseAddressForParams src/ and ensure all import statements are referring to cashMethods.js rather than Ticker.js
- npm test
- npm start
- regression test scanning of a valid and invalid QR code for address (use https://d14115.netlify.app/ on phone)
- regression test signing and verifying signatures
- regression test sending a token to an ecash address
- regression test sending XEC to an ecash address
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- parseAddressForParams_config
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 24160 Build 47930: Build Diff cashtab-tests Build 47929: arc lint + arc unit
Event Timeline
Comment Actions
This function is moved, and still there is no test change. This is an evidence that a unit test is missing.
Add these tests first then move the code, so the reviewer can be confident that there is no subtle change happening during the move because the test keeps passing.