Page MenuHomePhabricator
Differential D1411

Added script integration test intructions to developer-notes
ClosedPublic
Actions

Authored by jasonbcox on May 14 2018, 02:54.

Details

Reviewers
deadalnix
schancel
Group Reviewers
Restricted Project
Commits
rSTAGINGa317a4194fc2: Added script integration test intructions to developer-notes
rABCa317a4194fc2: Added script integration test intructions to developer-notes
Summary

Working on D1381 made it clear that these instructions are necessary, as they aren't documented anywhere.

Test Plan

D1381 shows these instructions are correct

Diff Detail

Repository
rABC Bitcoin ABC
Branch
script
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2603
Build 3320: Bitcoin ABC Buildbot (legacy)
Build 3319: arc lint + arc unit

Event Timeline

jasonbcox created this revision.May 14 2018, 02:54
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 14 2018, 02:54
teamcity added a subscriber: teamcity.May 14 2018, 02:57

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Harbormaster completed remote builds in B2579: Diff 3881.May 14 2018, 03:20
teamcity added a comment.May 14 2018, 03:20

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

schancel accepted this revision.May 14 2018, 23:42
This revision is now accepted and ready to land.May 14 2018, 23:42
deadalnix added inline comments.May 15 2018, 09:09
doc/developer-notes.md
213 ↗(On Diff #3881)

You know you can run just the script test ?

jasonbcox added inline comments.May 15 2018, 16:57
doc/developer-notes.md
213 ↗(On Diff #3881)

How? Do I specify a path after make check or something?

jasonbcox updated this revision to Diff 3919.May 21 2018, 19:31

Narrowed instructions to just run the specified test

jasonbcox marked 2 inline comments as done.May 21 2018, 19:32
teamcity added a comment.May 21 2018, 19:33

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing started.

teamcity added a comment.May 21 2018, 20:07

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2603: Diff 3919.May 21 2018, 20:07
Closed by commit rABCa317a4194fc2: Added script integration test intructions to developer-notes (authored by jasonbcox). · Explain WhyMay 21 2018, 22:08
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
doc/
11 lines

Diff 3919

View Options

doc/developer-notes.md

Loading...