Page MenuHomePhabricator
Differential D14127

[alias-server] Update getAliasInfoFromAlias to not return _id field
ClosedPublic
Actions

Authored by bytesofman on Jun 26 2023, 18:27.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCb16702f2528f: [alias-server] Update getAliasInfoFromAlias to not return _id field
Summary

T3060

User does not need this field and it complicates the unit tests for the API endpoint that will use this function. Remove.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
alias-server-patch-db
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 24184
Build 47978: Build Diffalias-server-tests
Build 47977: arc lint + arc unit

Event Timeline

bytesofman created this revision.Jun 26 2023, 18:27
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 26 2023, 18:27
bytesofman requested review of this revision.Jun 26 2023, 18:27
Harbormaster completed remote builds in B24184: Diff 41003.Jun 26 2023, 18:29
bytesofman added a child revision: D14129: [alias-server] Add quotes to make error log less ambiguous.Jun 26 2023, 18:36
Fabien added a subscriber: Fabien.Jun 26 2023, 19:26
Fabien added inline comments.
apps/alias-server/test/dbTests.js
233

It had no _id field to begin with ? Did you want to apply this to aliasInfo ?

bytesofman added inline comments.Jun 26 2023, 19:53
apps/alias-server/test/dbTests.js
233

It gets one below, when await addOneAliasToDb(testDb, newMockAlias); is called

Unit test will fail bc of this difference unless we compare to the clone version

Fabien accepted this revision.Jun 27 2023, 07:08
This revision is now accepted and ready to land.Jun 27 2023, 07:08
Closed by commit rABCb16702f2528f: [alias-server] Update getAliasInfoFromAlias to not return _id field (authored by bytesofman). · Explain WhyJun 27 2023, 16:30
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABCb16702f2528f: [alias-server] Update getAliasInfoFromAlias to not return _id field.

Revision Contents
Changeset List

PathSize
apps/
alias-server/
src/
4 lines
test/
4 lines

Diff 41003

View Options

apps/alias-server/src/db.js

Loading...
View Options

apps/alias-server/test/dbTests.js

Loading...