Page MenuHomePhabricator

[alias-server] Update getAliasInfoFromAlias to not return _id field
ClosedPublic

Authored by bytesofman on Jun 26 2023, 18:27.

Details

Summary

T3060

User does not need this field and it complicates the unit tests for the API endpoint that will use this function. Remove.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien added inline comments.
apps/alias-server/test/dbTests.js
233 ↗(On Diff #41003)

It had no _id field to begin with ? Did you want to apply this to aliasInfo ?

apps/alias-server/test/dbTests.js
233 ↗(On Diff #41003)

It gets one below, when await addOneAliasToDb(testDb, newMockAlias); is called

Unit test will fail bc of this difference unless we compare to the clone version

This revision is now accepted and ready to land.Jun 27 2023, 07:08