Differential D14144

[Cashtab] Improve cashtabCacheKeys validation logic
ClosedPublic
Actions

Authored by emack on Jun 28 2023, 12:18.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABCa9f7a4333f8d: [Cashtab] Improve cashtabCacheKeys validation logic

Summary

Address the cashtabCacheKeys validation antipattern identified in D14122

Test Plan

npm test

Diff Detail

Repository

rABC Bitcoin ABC

Branch

cashtabCacheKeys

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 24229
Build 48068: Build Diff	cashtab-tests
Build 48067: arc lint + arc unit

Event Timeline

emack created this revision.Jun 28 2023, 12:18

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 28 2023, 12:18

emack requested review of this revision.Jun 28 2023, 12:18

Harbormaster completed remote builds in B24229: Diff 41068.Jun 28 2023, 12:21

bytesofman accepted this revision.Jun 28 2023, 13:23

This revision is now accepted and ready to land.Jun 28 2023, 13:23

Closed by commit rABCa9f7a4333f8d: [Cashtab] Improve cashtabCacheKeys validation logic (authored by emack). · Explain WhyJun 29 2023, 00:07

This revision was automatically updated to reflect the committed changes.

emack added a commit: rABCa9f7a4333f8d: [Cashtab] Improve cashtabCacheKeys validation logic.

Revision Contents
Changeset List

Path

Size

cashtab/

src/

utils/

validation.js

6 lines

Diff 41068

View Options

cashtab/src/utils/validation.js

[Cashtab] Improve cashtabCacheKeys validation logicClosedPublicActions