[e.cash] Add blog page
ClosedPublic
Actions

Authored by johnkuney on Jun 28 2023, 21:25.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC7f88b3b3d3e8: [e.cash] Add blog page

Summary

Adding the main blog page to the site

use the getBlogPosts function from the last diff to getStaticProps for all of the posts
render them on the page in a series of cards

note the theme color change is for this diff. That value worked better here and for the other places its used

Test Plan

preview the site and see if everything looks good
npm run test

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

johnkuney created this revision.Jun 28 2023, 21:25

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 28 2023, 21:25

johnkuney requested review of this revision.Jun 28 2023, 21:25

Harbormaster completed remote builds in B24246: Diff 41096.Jun 28 2023, 21:25

@bot preview e.cash

The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.

The dateConvert function/tests should be its own diff

This revision now requires changes to proceed.Jun 29 2023, 06:24

remove date format

Harbormaster completed remote builds in B24253: Diff 41108.Jun 29 2023, 14:39

@bot preview e.cash

The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.

@bot preview-e.cash

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://54.39.19.73:41699 for the next 60 minutes.

Added a date convert function to render the dates in a nice way from the timestamps

Is that still a thing ? I can't see it in the diff

johnkuney edited the summary of this revision. (Show Details)Jun 29 2023, 16:01

@bot preview-e.cash

web/e.cash/pages/blog.js
27 ↗	(On Diff #41108)	worth defining 3 as a constant to this component e.g. `const FEATURED_POSTS_COUNT = 3`
56 ↗	(On Diff #41108)	then this is also FEATURED_POSTS_COUNT alt: define at the top, featuredPosts = props.posts.slice(0,3) posts = props.posts.slice(3) ...prob the better appproach, easier to read `featuredPosts.map(` vs `props.posts.slice(0,3).map(`...)
web/e.cash/styles/theme.js
54 ↗	(On Diff #41108)	what was the purpose of adding this change here? did the previous color conflict with something on the new page?

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://54.39.19.73:41616 for the next 60 minutes.

bytesofman added inline comments.Jun 29 2023, 18:33

web/e.cash/styles/theme.js
54 ↗	(On Diff #41108)	oh ok i see your comment in the desc.

at this point in the stack -- blog links are expected to 404? still pending a logic to add those pages at build time?

define featured post and post at top

Harbormaster completed remote builds in B24254: Diff 41110.Jun 29 2023, 19:24

In D14157#316364, @bytesofman wrote:

at this point in the stack -- blog links are expected to 404? still pending a logic to add those pages at build time?

Yes, need to create a post page and get the staticPaths, assumed should be a separate diff

Fabien accepted this revision.Jun 29 2023, 19:37

Fabien added inline comments.