Paths

Table of Contentst

Differential D14161

[ecash-herald] Patch bug in determining tokenId from SWaP txs
ClosedPublic
Actions

Authored by bytesofman on Jun 29 2023, 23:44.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC5dc3be44f638: [ecash-herald] Patch bug in determining tokenId from SWaP txs

Summary

T2972

tokenId is only found at stackArray[3] for a signal SLP Atomic Swap, not a payment SLP Atomic Swap.

Correct code logic to accurately reflect spec.

Test Plan

npm test

npm run sendMsgByBlock 798428 and no error msg

Diff Detail

Repository

rABC Bitcoin ABC

Branch

herald-patch-swap-parse-bug

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 24256
Build 48122: Build Diff	ecash-herald-tests
Build 48121: arc lint + arc unit

Event Timeline

bytesofman created this revision.Jun 29 2023, 23:44

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 29 2023, 23:44

bytesofman requested review of this revision.Jun 29 2023, 23:44

Harbormaster completed remote builds in B24256: Diff 41113.Jun 29 2023, 23:46

It looks like there is no test covering this case.

This revision now requires changes to proceed.Jun 30 2023, 07:26

adding test case to swap app tx mocks

Harbormaster completed remote builds in B24261: Diff 41119.Jun 30 2023, 13:03

PiRK accepted this revision.Jun 30 2023, 13:14

This revision is now accepted and ready to land.Jun 30 2023, 13:14

Closed by commit rABC5dc3be44f638: [ecash-herald] Patch bug in determining tokenId from SWaP txs (authored by bytesofman). · Explain WhyJun 30 2023, 16:35

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC5dc3be44f638: [ecash-herald] Patch bug in determining tokenId from SWaP txs.

Revision Contents
Changeset List

Path

Size

apps/

ecash-herald/

src/

parse.js

2 lines

Diff 41113

View Options

apps/ecash-herald/src/parse.js

[ecash-herald] Patch bug in determining tokenId from SWaP txsClosedPublicActions