Page MenuHomePhabricator
Differential D14176

[ecash-herald] Log success msgs by blockheight
ClosedPublic
Actions

Authored by bytesofman on Jun 30 2023, 20:10.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABCd2c98db02c97: [ecash-herald] Log success msgs by blockheight
Summary

T2972

Depends on D14175

Log blockheight success msg if msg(s) successfully sent for a given blockheight

Useful for reviewing logs and seeing if any blocks were missed

Test Plan

Confirm change only adds a log that only happens if an optional param is passed, npm test still good

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bytesofman created this revision.Jun 30 2023, 20:10
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 30 2023, 20:10
bytesofman requested review of this revision.Jun 30 2023, 20:10
Harbormaster completed remote builds in B24275: Diff 41138.Jun 30 2023, 20:11
bytesofman updated this revision to Diff 41139.Jun 30 2023, 20:12

Add to script to test

bytesofman edited the summary of this revision. (Show Details)Jun 30 2023, 20:13
bytesofman added a parent revision: D14175: [ecash-herald] Remove useless info from prod logs.

image.png (116×468 px, 11 KB)

Harbormaster completed remote builds in B24276: Diff 41139.Jun 30 2023, 20:14
bytesofman updated this revision to Diff 41140.Jun 30 2023, 20:15

Access blockheight same way as function

Harbormaster completed remote builds in B24277: Diff 41140.Jun 30 2023, 20:17
Fabien added a subscriber: Fabien.Jul 1 2023, 07:02
Fabien added inline comments.
apps/ecash-herald/src/telegram.js
132 ↗(On Diff #41140)

you can't send the genesis then ?

bytesofman updated this revision to Diff 41164.Jul 1 2023, 21:06

Better conditional logic

bytesofman marked an inline comment as done.Jul 1 2023, 21:07
bytesofman added inline comments.
apps/ecash-herald/src/telegram.js
132 ↗(On Diff #41140)

did send, but did not print desired log statement

resolved by update

image.png (105×413 px, 10 KB)

Harbormaster completed remote builds in B24296: Diff 41164.Jul 1 2023, 21:15
PiRK accepted this revision.Jul 2 2023, 06:11
This revision is now accepted and ready to land.Jul 2 2023, 06:11
Closed by commit rABCd2c98db02c97: [ecash-herald] Log success msgs by blockheight (authored by bytesofman). · Explain WhyJul 2 2023, 13:03
This revision was automatically updated to reflect the committed changes.
bytesofman marked an inline comment as done.
bytesofman added a commit: rABCd2c98db02c97: [ecash-herald] Log success msgs by blockheight.

Revision Contents
Changeset List

PathSize
apps/
ecash-herald/
scripts/
11 lines
src/
4 lines
11 lines

Diff 41186

View Options

apps/ecash-herald/scripts/sendMsgByBlock.js

Loading...
View Options

apps/ecash-herald/src/events.js

Loading...
View Options

apps/ecash-herald/src/telegram.js

Loading...