[ecash-herald] Standardize headers for msg sections
ClosedPublic
Actions

Authored by bytesofman on Jun 30 2023, 20:22.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC1d4b6e510a4b: [ecash-herald] Standardize headers for msg sections

Summary

T2972

Standardize headers for msg sections. All headers should have bold titles, include a count, be bolded, and not end with ':'

Test Plan

npm test

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bytesofman created this revision.Jun 30 2023, 20:22

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 30 2023, 20:22

bytesofman requested review of this revision.Jun 30 2023, 20:22

Harbormaster completed remote builds in B24278: Diff 41141.Jun 30 2023, 20:23

The mock data changes are a bit hard to review because it has a lot of unrelated changes. I understand the change in fiat rates, but other changes are confusing (block heights, txids, amounts...)

The code changes look OK.

In D14177#317122, @PiRK wrote:

The mock data changes are a bit hard to review because it has a lot of unrelated changes. I understand the change in fiat rates, but other changes are confusing (block heights, txids, amounts...)

The code changes look OK.

Reviewing the changes in this one -- seems like the "weird" changes are coming from changes to outputScriptInfoMap. This is expected as outputScriptInfoMap is storing data about utxos for addresses in theses blocks -- the utxo set for these addresses could arbitrarily change from one diff to the next based on network activity.

It would (probably) be better if these mocks were always generated with the same utxo data. I think tho beyond the scope of this diff.

PiRK accepted this revision.Jul 3 2023, 05:39

This revision is now accepted and ready to land.Jul 3 2023, 05:39

rebase, pushing to confirm fixed appropriately

This revision was landed with ongoing or failed builds.Jul 3 2023, 11:59

Closed by commit rABC1d4b6e510a4b: [ecash-herald] Standardize headers for msg sections (authored by bytesofman). · Explain Why

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC1d4b6e510a4b: [ecash-herald] Standardize headers for msg sections.

Harbormaster completed remote builds in B24321: Diff 41208.Jul 3 2023, 12:00