[Cashtab][Alias] Deprecate getAliasServerState
AbandonedPublic
Actions

Authored by emack on Jul 1 2023, 12:20.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Summary

T3216

No need for cashtab to monitor alias server state to compare onchain and cached alias counts due to local caching becoming redundant in subsequent diffs (see T3216).

Test Plan

npm test

Diff Detail

Repository

rABC Bitcoin ABC

Branch

getAliasServerState

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 24294
Build 48198: Build Diff	cashtab-tests
Build 48197: arc lint + arc unit

Event Timeline

emack created this revision.Jul 1 2023, 12:20

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 1 2023, 12:20

emack requested review of this revision.Jul 1 2023, 12:20

Harbormaster completed remote builds in B24294: Diff 41159.Jul 1 2023, 12:23

bytesofman requested changes to this revision.Jul 1 2023, 21:23

bytesofman added inline comments.

cashtab/src/hooks/useWallet.js
1129	seems like we can deprecate this whole function -- why do we need to deprecate only part of it? I get that could be the next diff. But kind of pointless to leave it here when it's going away.

This revision now requires changes to proceed.Jul 1 2023, 21:23

emack requested review of this revision.Jul 1 2023, 23:01

emack marked an inline comment as done.

emack added inline comments.

cashtab/src/hooks/useWallet.js
1129	This function is called in numerous places throughout cashtab and if we remove it in one go then this would be a very large diff spanning refactors across different components and making it a challenge to troubleshoot regressions

emack abandoned this revision.Jul 2 2023, 00:46

emack marked an inline comment as done.

emack added inline comments.

cashtab/src/hooks/useWallet.js
1129	This function is called in numerous places throughout cashtab and if we remove it in one go then this would be a very large diff spanning refactors across different components and making it a challenge to troubleshoot regressions scratch that, you're right, deprecating `getLatestAliases` in its entirety is fine as it's contained within useWallet. My comment above was mistakenly in the context of caching.