Page MenuHomePhabricator

[ecash-herald] Add basic validation checks to make app robust against unexpectedly formed OP_RETURN txs
ClosedPublic

Authored by bytesofman on Jul 4 2023, 21:24.

Details

Summary

It would be possible to crash ecash-herald by using known protocol identifiers to create OP_RETURN stacks of unexpected shape. Stop treating spec (including some unwritten spec) as natural law.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
more-robust-opreturn-parsing
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 24352
Build 48313: Build Diffecash-herald-tests
Build 48312: arc lint + arc unit