Now that we have an address directory, it can be interesting to know when some addresses are sending to themselves
Details
Details
- Reviewers
Fabien - Group Reviewers
Restricted Project - Commits
- rABCef6459c4fcb1: [ecash-herald] Show address for self-send txs when there is only 1 address
npm test
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- herald-show-selfsend-addr
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 24410 Build 48420: Build Diff ecash-herald-tests Build 48419: arc lint + arc unit
Event Timeline
Comment Actions
Need a way to show this in a unit test without a mock block, or a good mock block to add
Comment Actions
The test vectors are going out of control: this is adding > 1000 lines of data in blocks.js where >95% of it is irrelevant for this change.
You really need to sort this out.
Comment Actions
Now that generateMocks is configured to not overwrite an existing mocked block, can just build a fake block that shows new features.
Comment Actions
Now that we are only dealing with one block -- you can see this already-tested txid has changed its output
(The very last text in the left/right diff change section for block.js, 🐳1 address ➡️ itself becomes 🐳 Binance ➡️ itself
