Paths

Table of Contentst

Differential D14231

[ecash-herald] Show address for self-send txs when there is only 1 address
ClosedPublic
Actions

Authored by bytesofman on Jul 7 2023, 18:56.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCef6459c4fcb1: [ecash-herald] Show address for self-send txs when there is only 1 address

Summary

Now that we have an address directory, it can be interesting to know when some addresses are sending to themselves

Test Plan

npm test

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bytesofman created this revision.Jul 7 2023, 18:56

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 7 2023, 18:56

bytesofman requested review of this revision.Jul 7 2023, 18:56

Need a way to show this in a unit test without a mock block, or a good mock block to add

Harbormaster completed remote builds in B24410: Diff 41324.Jul 7 2023, 18:57

Add test block to cover case

Harbormaster completed remote builds in B24434: Diff 41358.Jul 10 2023, 17:11

The test vectors are going out of control: this is adding > 1000 lines of data in blocks.js where >95% of it is irrelevant for this change.
You really need to sort this out.

This revision now requires changes to proceed.Jul 10 2023, 19:24

Now that generateMocks is configured to not overwrite an existing mocked block, can just build a fake block that shows new features.

Add feature where txid is already tested

Now that we are only dealing with one block -- you can see this already-tested txid has changed its output

(The very last text in the left/right diff change section for block.js, 🐳1 address ➡️ itself becomes 🐳 Binance ➡️ itself

Harbormaster completed remote builds in B24515: Diff 41474.Jul 17 2023, 17:23

Fabien accepted this revision.Jul 18 2023, 14:28

This revision is now accepted and ready to land.Jul 18 2023, 14:28

Closed by commit rABCef6459c4fcb1: [ecash-herald] Show address for self-send txs when there is only 1 address (authored by bytesofman). · Explain WhyJul 18 2023, 23:45

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABCef6459c4fcb1: [ecash-herald] Show address for self-send txs when there is only 1 address.

Revision Contents
Changeset List

Path

Size

apps/

ecash-herald/

src/

parse.js

12 lines

test/

mocks/

block.js

2 lines

Diff 41508

View Options

apps/ecash-herald/src/parse.js