[Cashtab][Alias] Move getAliasRegistrationFee into aliasUtils
ClosedPublic
Actions

Authored by emack on Jul 10 2023, 05:54.

Details

Reviewers

bytesofman
Fabien

Group Reviewers

Restricted Project

Commits

rABC0451ed1fb8a7: [Cashtab][Alias] Move getAliasRegistrationFee into aliasUtils

Summary

T3216

All alias related utilities are being consolidated in aliasUtils, hence moving getAliasRegistrationFee and it's helper function getAliasByteSize (only used in getAliasRegistrationFee).
Associated unit tests migrated accordingly.

Test Plan

grep -r getAliasRegistrationFee src/ and ensure references are to aliasUtils.js
grep -r getAliasByteSize src/ and ensure references are to aliasUtils.js
npm test
set alias flag to true in Ticker.js
npm start
navigate to Alias page, input an alias and ensure the size/price preview is correct

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emack created this revision.Jul 10 2023, 05:54

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 10 2023, 05:54

emack requested review of this revision.Jul 10 2023, 05:54

Harbormaster completed remote builds in B24424: Diff 41346.Jul 10 2023, 05:56

OK with the function move, but the registration fees should not be hardcoded in cashtab. A much better strategy is to gather them from the alias server via some endpoint so maintenance happens at a single place and the price is publicly accessible to anybody without having to dig into the spec. It also can be changed much more easily if somebody else decides to build another registration app.

This revision is now accepted and ready to land.Jul 10 2023, 16:17

In D14239#318337, @Fabien wrote:

OK with the function move, but the registration fees should not be hardcoded in cashtab. A much better strategy is to gather them from the alias server via some endpoint so maintenance happens at a single place and the price is publicly accessible to anybody without having to dig into the spec. It also can be changed much more easily if somebody else decides to build another registration app.

yup agreed, Joey's got the price endpoint going now so there'll be an upcoming diff to use that as the single source of truth.

Closed by commit rABC0451ed1fb8a7: [Cashtab][Alias] Move getAliasRegistrationFee into aliasUtils (authored by emack). · Explain WhyJul 11 2023, 07:11

This revision was automatically updated to reflect the committed changes.

emack added a commit: rABC0451ed1fb8a7: [Cashtab][Alias] Move getAliasRegistrationFee into aliasUtils.