[electrum] README.md follow-ups
ClosedPublic
Actions

Authored by PiRK on Jul 12 2023, 10:05.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC1bb818c59b3a: [electrum] README.md follow-ups

Summary

D14250 broke the setup.py script and missed the needed update in MANIFEST.in

Fix it.

Test Plan

Make sure the setup.py script now works, build the source package and check that it contains README.md:

cd electrum
python setup.py --version
contrib/build-linux/srcdist-docker/build.sh && tar tvf dist/ElectrumABC-5.2.5.tar.gz | grep README.md

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Jul 12 2023, 10:05

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 12 2023, 10:05

PiRK requested review of this revision.Jul 12 2023, 10:05

Harbormaster completed remote builds in B24466: Diff 41408.Jul 12 2023, 10:06

PiRK edited the summary of this revision. (Show Details)Jul 12 2023, 11:48

PiRK edited the test plan for this revision. (Show Details)Jul 12 2023, 11:51

Fabien accepted this revision.Jul 12 2023, 13:54

This revision is now accepted and ready to land.Jul 12 2023, 13:54

We should look into getting CI jobs to avoid this class of issues

In D14258#318866, @Fabien wrote:

We should look into getting CI jobs to avoid this class of issues

I was thinking of this. For the setup breakage, simply running the test plan setup.py --version would be enough to check that no obvious error is introduced.
Eventually I think we will want to build the release binaries as part of CI tests, but with the current ubuntu packages repo breaking the build every two weeks it is not a good idea, so some work need to happen first.

Closed by commit rABC1bb818c59b3a: [electrum] README.md follow-ups (authored by PiRK). · Explain WhyJul 12 2023, 14:05

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC1bb818c59b3a: [electrum] README.md follow-ups.

PiRK mentioned this in D14260: [electrum] add a basic test for setup.py.Jul 12 2023, 16:00

PiRK mentioned this in rABCcfbb96bfc913: [electrum] add a basic test for setup.py.Jul 12 2023, 20:47