Page MenuHomePhabricator
Differential D1425

Add log for clearing the mempool during reorg
ClosedPublic
Actions

Authored by schancel on May 17 2018, 02:47.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING1b4c979a2632: Add log for clearing the mempool during reorg
rABC1b4c979a2632: Add log for clearing the mempool during reorg
Summary

Add a trace level log for when the mempool is cleared by a reorg.

Test Plan
make check && ./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

schancel created this revision.May 17 2018, 02:47
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 17 2018, 02:47
teamcity added a subscriber: teamcity.May 17 2018, 02:48

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing started.

Harbormaster failed remote builds in B2595: Diff 3903!May 17 2018, 03:03
teamcity added a comment.May 17 2018, 03:03

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing failed.

deadalnix requested changes to this revision.May 17 2018, 04:05
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/validation.cpp
2606 ↗(On Diff #3903)

::ALL is not meant to be a logging category, but mask representing all logging categories.

This revision now requires changes to proceed.May 17 2018, 04:05
schancel added inline comments.May 17 2018, 06:59
src/validation.cpp
2606 ↗(On Diff #3903)

What do we use for trace level logs?

jasonbcox added a subscriber: jasonbcox.May 20 2018, 23:58
jasonbcox added inline comments.
src/validation.cpp
2606 ↗(On Diff #3903)

@deadalnix How about we make this more explicit? https://reviews.bitcoinabc.org/D1431 I've fallen into the same trap where I tried to log on ALL. Not that it was explicitly a compile or runtime issue, but it took me a while to realize that what I was doing was conceptually incorrect.

schancel updated this revision to Diff 4041.May 31 2018, 02:06

Update log level.

teamcity added a comment.May 31 2018, 02:06

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing started.

teamcity added a comment.May 31 2018, 02:42

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2686: Diff 4041.May 31 2018, 02:42
jasonbcox accepted this revision.Jun 4 2018, 23:44
schancel removed a reviewer: deadalnix.Jun 4 2018, 23:45
This revision is now accepted and ready to land.Jun 4 2018, 23:45
Closed by commit rABC1b4c979a2632: Add log for clearing the mempool during reorg (authored by schancel). · Explain WhyJun 4 2018, 23:46
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
2 lines

Diff 4060

View Options

src/validation.cpp

Loading...